Display quick search dialog result in SourceViewer with line numbers. Fixes #2010 #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(following pictures were taken before #2541 (adding 'search in' combo box with history) was merged) Before After + caret located on line other than target line, caret line becomes highlighted as well |
1 task
RedeemerSK
force-pushed
the
issue_2010
branch
from
eaae0b5 to
d078088
Compare
|
Thats a nice addition. |
BeckerWdf
reviewed
Dec 23, 2024
| @@ -1030,47 +1168,6 @@ private StyledString highlightMatches(String visibleText) { | |||
| return styledText; | |||
| } | |||
|
|
|||
| // Version using sourceviewer | |||
There was a problem hiding this comment.
do we know why this was discarded in the first place?
There was a problem hiding this comment.
It was already there (see 1st commit) when QuickSearchDialog code was contributed from Spring Tools suite.
From what I can tell it was always just a protoype code - when I tried it uncommented it looked just like that.
RedeemerSK
commented
Jan 4, 2025
...eclipse.text.quicksearch/src/org/eclipse/text/quicksearch/internal/ui/QuickSearchDialog.java
Outdated
Show resolved
Hide resolved
RedeemerSK
commented
Jan 4, 2025
...eclipse.text.quicksearch/src/org/eclipse/text/quicksearch/internal/ui/QuickSearchDialog.java
Show resolved
Hide resolved
RedeemerSK
force-pushed
the
issue_2010
branch
from
b72a51b to
cefa208
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds line numbers (vertical ruler) when presenting content that contains searched term in Quick Search dialog. For this, simple StyledText widget that was used to present content was replaced with SourceViewer widget. It's configured with same colors like generic text editor.
(* current line highlighting must be enabled in preferences)
How to test
Open Quick Search dialog (default: CTRL + SHIFT + ALT + L) and confirm bottom area presenting parts of files where match was found behaves like it used to - displays match vertically centered, keeps it centered on resizing the dialog or area, displays match 'context' (lines before & after match within source file).
Known bugs
Changing theme (light <-> dark) while Quick Search dialog is open does not change all the colors used inside it (namely occurrences highlighting). Closing and reopening the dialog fixes the colors.
Author checklist