Use DS annotations instead of handcrafted XML #2135
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 815 files ±0 1 815 suites ±0 1h 31m 50s ⏱️ - 3m 6s For more details on these failures, see this check. Results for commit 24881ac. ± Comparison against base commit cd70f45. ♻️ This comment has been updated with latest results. |
laeubi
force-pushed
the
use_ds_annotations
branch
from
29ce5d7 to
24881ac
Compare
|
With #2344 this is obsolete isn't it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes a build warning due to usage of wildcard pattern for components, I don't see any reason to use a wildcard here.
Beside that, weight = 100 seems strange here as usually one would use a service ranking instead but I have leave this as-is for now.
FYI @robstryker