-
Notifications
You must be signed in to change notification settings - Fork 210
Regression: Line Numbers are broken in different ways on Linux/MacOS #2740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@akoch-yatta and @HeikoKlare can you please have a look? |
We have a look |
fix for eclipse-platform#2740
Whatever issues your I20230605-0440 version has is not related to recent regression. It is not the first time the line number ruler got a regression. It works fine with reverted 57666c4 and is broken with current master. So please provide a fix or we should revert 57666c4 as it makes line number ruler on Linux unusable. |
Sure, we'll do that. But we need to understand the reasons for the issue and actually all SDKs I am running on Linux (no matter whether the 2023-06 one, a recent but older I-Build one, or any other) show this behavior to a certain degree. I am able to produce broken line number rulers in all of them. So it's currently quite hard to understand what part of the behavior needs to be fixed, given that it was (at least on some environments) also broken before yesterday's change to a certain degree. Edit: In particular if I revert 57666c4, the issue is not fixed on my system but just occurs less often. |
Ugh. I'm using RHEL 9.2 and used to run RHEL 7.9 with almost every nightly SDK build till 4.35 broke compatibility to older Linux distros and I saw no issues with line number ruler (except few regressions clearly identified as such like this one here). I'm using What I clearly see is that 57666c4 commit breaks status quo and I see no problems with it reverted or in SDK build I20250119-1800. |
Good point. I am running Ubuntu with Wayland. I will test with X11 to hopefully have a state that worked before the commit introducing the regression as a baseline for comparison. Just as a "demonstration", this is how it looks with 57666c4 reverted for me: |
OK, let take Wayland out of equation. On X11 Eclipse must work. |
The current implementation of the Image constructor accepting an ImageGcDrawer does initialize the image with the given width and height but extracts them from the image data being initialized with the ImageGcDrawer. This does not take the current device zoom into account properly, leading to images unexpectedly being rendered for 100% scaling while they are supposed to be used at 200% scaling. With this change, images are properly initialized with the given width and height and using the according device zoom for the image data generation, leading to a sharp initialization also on 200% monitors. Serves as a fix for the MacOS part of issue eclipse-platform/eclipse.platform.ui#2740
…se-platform#2740 This temporarily reverts the image creation for the LineNumberRulerColumn on Linux to the state before initializing the buffer image with an ImageGcDrawer. This does currently not work properly for all use cases on Linux/GTK because of an issue with the initialization of Image based on existing ImageData due to the usage of cairo_image_surface_create. Linux-specific workaround for eclipse-platform#2740
The current implementation of the Image constructor accepting an ImageGcDrawer does initialize the image with the given width and height but extracts them from the image data being initialized with the ImageGcDrawer. This does not take the current device zoom into account properly, leading to images unexpectedly being rendered for 100% scaling while they are supposed to be used at 200% scaling. With this change, images are properly initialized with the given width and height and using the according device zoom for the image data generation, leading to a sharp initialization also on 200% monitors. Serves as a fix for the MacOS part of issue eclipse-platform/eclipse.platform.ui#2740
…se-platform#2740 This temporarily reverts the image creation for the LineNumberRulerColumn on Linux to the state before initializing the buffer image with an ImageGcDrawer. This does currently not work properly for all use cases on Linux/GTK because of an issue with the initialization of Image based on existing ImageData due to the usage of cairo_image_surface_create. Linux-specific workaround for eclipse-platform#2740
…se-platform#2740 This temporarily reverts the image creation for the LineNumberRulerColumn on Linux to the state before initializing the buffer image with an ImageGcDrawer. This does currently not work properly for all use cases on Linux/GTK because of an issue with the initialization of Image based on existing ImageData due to the usage of cairo_image_surface_create. Linux-specific workaround for eclipse-platform#2740
This temporarily reverts the image creation for the LineNumberRulerColumn on Linux to the state before initializing the buffer image with an ImageGcDrawer. This does currently not work properly for all use cases on Linux/GTK because of an issue with the initialization of Image based on existing ImageData due to the usage of cairo_image_surface_create. Linux-specific workaround for #2740
…latform#2740 The underlying issue for the required workaround on Linux/GTK was located in the GTK implementation of GC#copyArea() when source and target area of a copy operation are overlapping. Since that issue has been fixed, this change removes the temporary workaround in LineNumberRulerColumn. Fixes eclipse-platform#2740
…latform#2740 The underlying issue for the required workaround on Linux/GTK was located in the GTK implementation of GC#copyArea() when source and target area of a copy operation are overlapping. Since that issue has been fixed, this change removes the temporary workaround in LineNumberRulerColumn. Fixes eclipse-platform#2740
The underlying issue for the required workaround on Linux/GTK was located in the GTK implementation of GC#copyArea() when source and target area of a copy operation are overlapping. Since that issue has been fixed, this change removes the temporary workaround in LineNumberRulerColumn. Fixes #2740
Let's make sure issue is not already fixed in latest builds first.
Steps to reproduce
From a fresh installation and clean workspace:
I tried
I expected: line number to be sharp
But got: partly blurry line numbers at the top or the bottom. See
I think this is a regression from #2722
Tested under this environment:
Community
The text was updated successfully, but these errors were encountered: