[win32] Remove Image#initialNativeZoom #2064
Conversation
akoch-yatta
force-pushed
the
Remove-initialNativeZoom-in-Image
branch
8 times, most recently
from
52dd511 to
db7a3a1
Compare
akoch-yatta
force-pushed
the
Remove-initialNativeZoom-in-Image
branch
from
db7a3a1 to
e0c1ae7
Compare
akoch-yatta
force-pushed
the
Remove-initialNativeZoom-in-Image
branch
from
e0c1ae7 to
f3b211c
Compare
HeikoKlare
force-pushed
the
Remove-initialNativeZoom-in-Image
branch
from
f3b211c to
73d731c
Compare
| destroyHandles(zoom -> { | ||
| return !zoomLevels.contains(zoom) && zoom != DPIUtil.getZoomForAutoscaleProperty(initialNativeZoom); | ||
| }); | ||
| destroyHandles(zoom -> !zoomLevels.contains(zoom)); |
There was a problem hiding this comment.
May this now lead to all handles being destroyed if the (potentially single) zoom, for which a handle exists, is not in the list of excluded zoom levels? So, e.g., an image was create for 100% zoom, drawn with a GC, then monitor scaling is changed to 125%, so the handle is destroyed and the image painted via GC is lost?
There was a problem hiding this comment.
Yes, you probably could create a scenario like this. As you stated out, it would only affect images, that are changed with a GC afterwards. We already would have issues with GC when there were multiple handles created before, but we could introduce some kind of locking flag, when an image was used once with a GC to prevent it from cleaning up any handles here.
There was a problem hiding this comment.
Thank you for the fix regarding a plain image that may be initialized via GC. Looks fine to me.
akoch-yatta
force-pushed
the
Remove-initialNativeZoom-in-Image
branch
2 times, most recently
from
38787fc to
140e119
Compare
This commit removes Image#initialNativeZoom in the windows implementation. To achieve this all usages of this field are replaces by either using a concrete zoom values or by creating a temporary handle.
akoch-yatta
force-pushed
the
Remove-initialNativeZoom-in-Image
branch
from
140e119 to
d424a46
Compare
This PR removes Image#initialNativeZoom in the windows implementation. To achieve this all usages of this field are replaces by either using a concrete zoom values or by creating a temporary handle.