Skip to content

Replace usages of new Image(device, width, height) for Composite #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

Replace usages of new Image(device, width, height) for Composite #2004

merged 1 commit into from
Apr 25, 2025

Conversation

ShahzaibIbrahim
Copy link
Contributor

No description provided.

@ShahzaibIbrahim ShahzaibIbrahim linked an issue Apr 8, 2025 that may be closed by this pull request
Replace usages of new Image(device, width, height) / new GC(image) vi-eclipse/Eclipse-Platform#188
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025 •
edited
Loading

Test Results

   539 files  ±0     539 suites  ±0   30m 11s ⏱️ -39s
 4 337 tests ±0   4 321 ✅ +1   15 💤 ±0  1 ❌  - 1 
16 601 runs  ±0  16 463 ✅ +1  137 💤 ±0  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit e41f12b. ± Comparison against base commit 28fdeb6.

♻️ This comment has been updated with latest results.

@ShahzaibIbrahim ShahzaibIbrahim marked this pull request as ready for review April 22, 2025 08:23
@ShahzaibIbrahim ShahzaibIbrahim force-pushed the master-188-composite branch 3 times, most recently from 0ec4ab2 to 820e9db Compare April 22, 2025 13:24
@fedejeanne fedejeanne force-pushed the master-188-composite branch from 820e9db to e41f12b Compare April 25, 2025 09:33
fedejeanne
fedejeanne approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@fedejeanne fedejeanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahzaibIbrahim thank you, the changes LGTM.

fyi I made one slight alteration and let paintGC be initialized inside of the if (just like it was before). The reason for this is that I wouldn't want to initialize it if the style-bit SWT.TRANSPARENT is not set, which was a pre-requisite before your PR.

@fedejeanne
Copy link
Contributor

Failing test is unrelated #1843

@fedejeanne
Copy link
Contributor

Version increment check is failing for infrastructure reasons and no further version bump is required here.

@fedejeanne fedejeanne merged commit 807b159 into eclipse-platform:master Apr 25, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedejeanne fedejeanne fedejeanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace usages of new Image(device, width, height) / new GC(image)
2 participants
@ShahzaibIbrahim @fedejeanne