-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser tests: reduce timeout for instantiation to reasonable value #1706
base: master
Are you sure you want to change the base?
Browser tests: reduce timeout for instantiation to reasonable value #1706
Conversation
Test Results 493 files - 1 493 suites - 1 10m 21s ⏱️ + 1m 15s For more details on these failures, see this check. Results for commit 194a8a0. ± Comparison against base commit c493ae8. This pull request removes 37 tests.
♻️ This comment has been updated with latest results. |
a5eacf0
to
228c11e
Compare
228c11e
to
8cf3573
Compare
Builds sporadically show timeouts, e.g.:
Might be related to eclipse-platform/eclipse.platform.ui#2734 |
The timeout for browser instantiation in the browser tests has been increased to avoid flaky tests. However, browser instantiation taking more than 10 seconds (the previous timeout value) is an indicator for something being wrong with the instantiation. There is no reason why instantiation may take that long during test execution but the same issue should never arise in productive use, thus such a case should be captured by tests and, if necessary, be fixed productively. In order to do so, this change reduces the test timeout value again to a more reasonable value. Related to eclipse-platform#1676
8cf3573
to
194a8a0
Compare
The timeout for browser instantiation in the browser tests has been increased to avoid flaky tests (via #1677). However, browser instantiation taking more than 10 seconds (the previous timeout value) is an indicator for something being wrong with the instantiation. There is no reason why instantiation may take that long during test execution but the same issue should never arise in productive use. Thus, such a case should be captured by tests and, if necessary, be fixed productively.
In order to do so, this change reduces the test timeout value again to a more reasonable value.
Related to #1676
Also see #1677 (comment)