Remove -Djava.security.manager=allow from the products

[merks]

• Define an unconfigure touchpoint to remove -Djava.security.manager=allow from the eclipse.ini which is done to ensure that updates will leave installations in a state that can run with Java 24.
• Do the above for both products and ensure that both products specify -Dosgi.requiredJavaVersion=21

#2623

[merks]

This approach is an alternative to just removing the -Djava.security.manager=allow from the products which would leave existing updated installations forever with that option in their eclipse.ini, eventually failing to start with Java 24. It's also an alternative to setting -Djava.security.manager=disallow in the product which might cause problems immediately (though ones that will definitely happen with Java 24 eventually), and that being said, the default for Java 21 is dissallow so setting it to that explicitly would maybe be fine too. I'm not sure how others @HannesWell @laeubi @akurtakov @jonahgraham @iloveeclipse feel about this?

An unconfigure is used because the existing product IUs' p2 metadata looks like this:

<instruction key="configure">
...;addJvmArg(jvmArg:-Djava.security.manager=allow);...
</instruction>
<instruction key="unconfigure">
...;removeJvmArg(jvmArg:-Djava.security.manager=allow);...
</instruction>

[akurtakov]

It looks like the correct thing to do (removing setting to default value that we know will break soon )

[merks]

I'll leave this open for 24 hours for anyone else to comment.

[laeubi]

I'm fine with that even though I probably would not have came up with such an sophisticated approach :-)

[merks]

Thanks @laeubi for pointing out that there were two separate instructions.configure properties!

[merks]

Darn, now there are two commits. I will force push again...

[merks]

@akurtakov

An earlier build passed all the tests but now the license Java 21 issue appears to be back. Do you have idea of why that might be?

[akurtakov]

I rerun it (just in case :) and it failed again. Looking into it.

[akurtakov]

@merks Fixed via #2674 .
Until eclipse-dash/dash-licenses#423 is applied projects will have to apply similar change to keep licensecheck working for them.

[merks]

Oh joy:

14:27:29  Caused by: java.lang.OutOfMemoryError: Java heap space
14:27:29      at org.codehaus.plexus.archiver.zip.ByteArrayOutputStream.needNewBuffer (ByteArrayOutputStream.java:153)

Repeating builds doesn't warm my heart but the warms the planet.

[HannesWell]

Thank you for working out the details.
Removing existing java.security.manager=allow is probably the best we can do, because not everyone can consider changed defaults:
#2659 (comment)

[jonahgraham]

I'll pick up the same changes for the EPP products when I do the following for 2025-03 M1 eclipse-packaging/packages#251

• Synchronize the following - Remember to check branch, these links are to master, but around RC2 master may be setup for next release already
• Synchronize any changes to platform.product into all the epp.product files.
• Synchronize any changes to platform.p2.inf into all the *.product/p2.inf files.

[merks]

Thanks everyone for the feedback! 💞