[I-Build-Test] Remove CPU-arch as criterion for testPlatform property #2487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All usages depending on the 'testPlatform' variable don't distinguish between architectures. In case it is attempted to run the tests on a unsupported arch, checking the architecture too produces an explicit error message instead of just having a download that fails because the corresponding artifacts are not available. But those that run I-builds locally or configure a new platform are usually well aware if the executing architecture is supported or not. And testing for the arch just makes it more complicated to run tests on new platforms.
HannesWell
force-pushed
the
remove-explicit-arch-check
branch
from
bd66957 to
dbe1232
Compare
|
If there are no objection's I'll submit this tomorrow (Tuesday) evening. |
|
No objection from me. Big thanks for deep diving into our most cumbersome releng parts! |
|
You're welcome, it's always nice to get a bit of configuration, even if there is still huge amount left. Let's have this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All usages depending on the 'testPlatform' variable don't distinguish between architectures.
In case it is attempted to run the tests on a unsupported arch, checking the architecture too produces an explicit error message instead of just having a download that fails because the corresponding artifacts are not available. But those that run I-builds locally or configure a new platform are usually well aware if the executing architecture is supported or not.
And testing for the arch just makes it more complicated to run tests on new platforms.
This helps for example for #577.