Add delete permissions on File models #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the moment I think we should avoid the complexity of checking the file service. Let's wait and see if it is needed. Because if we start doing so on deletion, we should also be checking on updates to the File object. |
|
IMO it's a little awkward, but manageable for the UI to manage the file bytes and File entity in this way. I agree, though, that we should wait to see if there's feedback about file it before looking into potential changes |
markpatton
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of eclipse-pass/main#514
Would we want to first check if the uploaded bytes on the file system are gone (referenced in
file.uri)?