Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set USER for docker #109

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Set USER for docker #109

merged 3 commits into from
Jan 9, 2025

Conversation

rpoet-jh
Copy link
Contributor

@rpoet-jh rpoet-jh commented Jan 9, 2025 •
edited
Loading

This PR updates the Dockerfile so the pass-core docker container runs with a non-privileged user.

I have tested this locally in pass-docker and acceptance tests pass.

@rpoet-jh rpoet-jh self-assigned this Jan 9, 2025
@rpoet-jh rpoet-jh requested a review from markpatton January 9, 2025 14:34
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

markpatton
markpatton approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Runs locally for me.

@rpoet-jh rpoet-jh merged commit 219cb8c into main Jan 9, 2025
3 checks passed
@rpoet-jh rpoet-jh deleted the rdp-1107-docker-user branch January 16, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markpatton markpatton markpatton approved these changes

Assignees

@rpoet-jh rpoet-jh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpoet-jh @markpatton