Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate pass-auth and pass-docker reverse proxy functionality into pass-core #903

Assignees
Labels
Milestone

Comments

@markpatton
Copy link
Contributor

markpatton commented Feb 15, 2024

What?

The PASS API should be easy to deploy and it should be easy to understand how authentication is handled. In order to do that, pass-core should take over the functionality of pass-auth and the pass-docker reverse proxy. The pass-docker environments will also need to updated.

Why?

The current pass-docker architecture is complicated interleaving a reverse proxy, pass-auth, and pass-core. Instead pass-core should take over that functionality. See https://docs.google.com/document/d/1swYRvwNeouMyuG9xEbSBLFffUpBstllI1bP5Zcsx3ME/edit?usp=sharing for more information.

How?

See the above linked document for information on what routes pass-auth and the reverse proxy currently handle and what pass-core needs to do. Spring security has support for SAML 2 which should help with the pass-auth functionality.

Acceptance Criteria

The pass-docker environments should be updated such that they can run the new pass-core. Show that Shib integration works on staging.

Related Issues

Blocking #907, #908, #909

@markpatton markpatton added the Improvement improvement or enhancement suggestions label Feb 15, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Eclipse PASS Feb 15, 2024
@dkriethof dkriethof added CI/CD and removed Improvement improvement or enhancement suggestions labels Feb 27, 2024
@dkriethof dkriethof moved this from Backlog to Ready for Development in Eclipse PASS Feb 27, 2024
@dkriethof dkriethof moved this from Ready for Development to Backlog in Eclipse PASS Feb 27, 2024
@dkriethof dkriethof added this to the 1.5.0 milestone Feb 27, 2024
@dkriethof dkriethof moved this from Backlog to Ready for Development in Eclipse PASS Feb 29, 2024
@markpatton markpatton moved this from Ready for Development to In Progress in Eclipse PASS Mar 7, 2024
@markpatton markpatton self-assigned this Mar 7, 2024
@tsande16 tsande16 modified the milestones: 1.5.0, 1.6.0 Mar 27, 2024
@markpatton
Copy link
Contributor Author

markpatton commented Apr 16, 2024

The major changes are the removal of pass-auth and the reverse proxy from pass-docker. Instead pass-core takes on those roles and handles SAML authentication as well as requests for pass-ui under /app/.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Eclipse PASS Apr 22, 2024
@markpatton markpatton reopened this Apr 22, 2024
@github-project-automation github-project-automation bot moved this from Done to Backlog in Eclipse PASS Apr 22, 2024
@dkriethof dkriethof moved this from Backlog to In Progress in Eclipse PASS Apr 23, 2024
@markpatton
Copy link
Contributor Author

Closing after testing on stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment