-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate pass-auth and pass-docker reverse proxy functionality into pass-core #903
Closed
markpatton opened this issue
Feb 15, 2024
· 2 comments
· Fixed by eclipse-pass/pass-core#82, eclipse-pass/pass-acceptance-testing#16, eclipse-pass/pass-support#104, eclipse-pass/pass-docker#365 or eclipse-pass/pass-ui#1260
Closed
Consolidate pass-auth and pass-docker reverse proxy functionality into pass-core #903
markpatton opened this issue
Feb 15, 2024
· 2 comments
· Fixed by eclipse-pass/pass-core#82, eclipse-pass/pass-acceptance-testing#16, eclipse-pass/pass-support#104, eclipse-pass/pass-docker#365 or eclipse-pass/pass-ui#1260
Comments
This was
linked to
pull requests
Apr 16, 2024
Merged
The major changes are the removal of pass-auth and the reverse proxy from pass-docker. Instead pass-core takes on those roles and handles SAML authentication as well as requests for pass-ui under /app/. |
Closing after testing on stage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What?
The PASS API should be easy to deploy and it should be easy to understand how authentication is handled. In order to do that, pass-core should take over the functionality of pass-auth and the pass-docker reverse proxy. The pass-docker environments will also need to updated.
Why?
The current pass-docker architecture is complicated interleaving a reverse proxy, pass-auth, and pass-core. Instead pass-core should take over that functionality. See https://docs.google.com/document/d/1swYRvwNeouMyuG9xEbSBLFffUpBstllI1bP5Zcsx3ME/edit?usp=sharing for more information.
How?
See the above linked document for information on what routes pass-auth and the reverse proxy currently handle and what pass-core needs to do. Spring security has support for SAML 2 which should help with the pass-auth functionality.
Acceptance Criteria
The pass-docker environments should be updated such that they can run the new pass-core. Show that Shib integration works on staging.
Related Issues
Blocking #907, #908, #909
The text was updated successfully, but these errors were encountered: