Fix logout bug in pass-auth #375

jaredgalanis · 2022-11-01T18:07:30Z

we use https://github.com/jaredhanson/passport
the most recent release of passport.js changed the signature for the logout method as described here: https://medium.com/passportjs/fixing-session-fixation-b2b68619c51d
unfortunately using this new method signature causes the logout process to hang
for now we've reverted to v0.5.3, but we should update to the latest version and fix whatever issue there is

The text was updated successfully, but these errors were encountered:

jabrah · 2023-12-18T15:13:56Z

Need to upgrade Passport versions and check relevance of this issue. If we consolidate pass-auth/proxy with pass-core, this will become irrelevant

jaredgalanis · 2024-03-06T13:43:57Z

Closing due to #903

jaredgalanis self-assigned this Nov 1, 2022

jaredgalanis moved this from Sprint 14 to Done in Eclipse PASS Nov 8, 2022

jaredgalanis moved this from Done to Todo in Eclipse PASS Nov 8, 2022

jaredgalanis moved this from Todo to In Progress in Eclipse PASS Jan 4, 2023

jaredgalanis moved this from In Progress to Todo in Eclipse PASS Jan 24, 2023

jaredgalanis added UI authentication labels Apr 13, 2023

markpatton moved this from Todo to Backlog in Eclipse PASS Apr 13, 2023

dkriethof moved this from Clean up/add to Backlog to Backlog in Eclipse PASS Jun 22, 2023

dkriethof added this to the Release 1.0.0 milestone Jul 20, 2023

dkriethof modified the milestones: Release 1.0.0, Post 1.0.0 Aug 29, 2023

dkriethof removed this from the Post 1.2.0 milestone Nov 28, 2023

jaredgalanis closed this as completed Mar 6, 2024

github-project-automation bot moved this from Backlog to Done in Eclipse PASS Mar 6, 2024

Provide feedback