Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the documentation for -XX:+MergeCompilerOptions #1392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luke-li-2003
Copy link

Included descriptions and examples when used with -Xint, -Xnoaot, and -Xnojit.

Included descriptions and examples when used with `-Xint`,
`-Xnoaot`, and `-Xnojit`.
@luke-li-2003
Copy link
Author

@mpirvu

@pshipton
Copy link
Member

@Sreekala-Gopakumar fyi

There are What's New and release notes to update as well. These either need to be included in PRs or an issue created for Sreekala to do it.

@pshipton
Copy link
Member

If this is for 0.48, it can't be merged now or it will affect the docs for 0.47 (Java 23).

@mpirvu
Copy link
Contributor

mpirvu commented Aug 20, 2024

If this is for 0.48, it can't be merged now or it will affect the docs for 0.47 (Java 23).

This PR intends to add more clarity to the documentation for -XX:+MergeCompilerOptions.
Typically, -Xjit options that appear on the command line before -Xint or -Xnojit are ignored. However, this is not the case if -XX:+MergeCompilerOptions is also present on the command line. -XX:+MergeCompilerOptions will concatenate all -Xjit options, even those appearing before a -Xint (or -Xnojit). I wanted this behavior to be clearly spelled-out in the documentation.

This PR is not critical and can wait until 0.47 is released.

@pshipton
Copy link
Member

If it's just for clarity and not related to any code change, then no What's New or release notes are required. It can be merged any time, and we could even update the 0.46 documentation to include it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants