Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix support for link-local IPv6 addresses #32

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benemorius
Copy link

This PR addresses link-local IPv6 handling in the broker by adding the interface ID (scope_id) as part of the address string for link-local clients.

This fixes the case where the broker receives a packet from a link-local IPv6 address and the reply is dropped due to not specifying which interface to send on.

See https://github.com/RIOT-OS/RIOT/tree/master/examples/emcute_mqttsn#i-see-incoming-messages-in-rsmb-but-no-outgoing-message-seems-to-arrive

@benemorius
Copy link
Author

Ping @ralight @njh

Copy link

@sloanyyc sloanyyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

char a[strlen(addr) + 1];
in most c compiler, Do not support none const stack alloc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants