Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handling scenario when getPathInfo() returns null #412

Merged
merged 2 commits into from
Oct 9, 2023
Merged

handling scenario when getPathInfo() returns null #412

merged 2 commits into from
Oct 9, 2023

Conversation

Jad-el-khoury
Copy link
Contributor

Description

When getPathInfo() returns null (user calls the domain, without any extra relative path), isProtectedResource() gets an exception.
Introduce logic to handle this scenario

Checklist

  • This PR adds an entry to the CHANGELOG. See https://keepachangelog.com/en/1.0.0/ for instructions. Minor edits are exempt.
  • This PR was tested on at least one Lyo OSLC server (e.g. manual workflow on Lyo Sample and OSLC RefImpl) or adds unit/integration tests.
  • This PR does NOT break the API

@Jad-el-khoury
Copy link
Contributor Author

@berezovskyi I made this small change to make all the checks work
https://github.com/eclipse/lyo/pull/412/files#diff-5dbf1a803ecc13ff945a08ed3eb09149a83615e83f15320550af8e3a91976446L33

@Jad-el-khoury Jad-el-khoury merged commit 41bf66f into master Oct 9, 2023
5 checks passed
@Jad-el-khoury Jad-el-khoury deleted the oauthBug branch October 9, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berezovskyi berezovskyi berezovskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jad-el-khoury @berezovskyi