Add OSGi metadata to the manifest of lemminx-maven #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently the lemminx-maven does not ship any OSGi metadata what makes it hard to use inside OSGi or even using OSGi techniques (e.g. to compute all its required dependencies using a resolver). As shipping OSGI metadata only has the cost of a few bytes in the manifest and many libraries already doing so it seems good to add them here as well.
laeubi
force-pushed
the
add_osgi_metadata
branch
from
d53e999 to
41c1a26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the lemminx-maven does not ship any OSGi metadata what makes it hard to use inside OSGi or even using OSGi techniques (e.g. to compute all its required dependencies using a resolver).
As shipping OSGI metadata only has the cost of a few bytes in the manifest and many libraries already doing so it seems good to add them here as well.