Fix 404 page's styling #238
Conversation
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
|
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
|
This is still draft, because I need to test as a deployment ftm because on local mode it does not show up the custom 404. The problem so far is that the |
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
|
Bah, it seems I cannot test it really on a preview server. The 404 page is a result of the HTTP server, which redirects to |
There was a problem hiding this comment.
This seems to break the GitHub PR preview:
https://eclipse-langium.github.io/langium-previews/pr-previews/pr-238/docs/
True. We need to set the correct base url before we are building. Otherwise it would be EDIT: @msujew I tried adding the base URL in the GH Action. But for some reason it seems to use the workflow file from main, not from the branch. Is there any way to test this locally? Do you know something? |
Lotes
temporarily deployed
to
pull-request-preview
GitHub Actions
Inactive
|
I've peeked at this too and it feels like hugo isn't responding to a myriad of ways to set a custom 404. The usual locations in layout, static, or even modifying the theme don't seem to have effect (notably the theme's own 404 isn't applied as expected). There can be a few reasons for this based on how we've customized the app, but we're also using an older version from about 3 years ago. I'm not sure how easily we could upgrade, but it might be worth checking if some newer version of hugo makes it easier to resolve this. |
|
I am closing this PR. No idea how to check this, without breaking something. |
Fixes #236