Fix typo in getting-started grammar #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it possible to read the docs on a phone
spoenemann
approved these changes
Oct 19, 2023
| @@ -75,7 +75,7 @@ Here's the grammar that parses the previous text snippet: | |||
| grammar HelloWorld | |||
|
|
|||
| hidden terminal WS: /\s+/; | |||
| terminal ID: /[_a-zA-Z][\w_]*/; | |||
| terminal ID: /[_a-zA-Z][\w]*/; | |||
There was a problem hiding this comment.
I didn't know the \w class includes the underscore. I think this could be improved in our main repo, too. We have one instance of that terminal rule in our Yeoman template, and also in the Langium grammar language and our example languages. If you like, you're welcome to make the improvement in those places as well.
emilkrebs
pushed a commit
that referenced
this pull request
Oct 25, 2023
* Fix typo in getting-started grammar * Make code blocks vertically scrollable To make it possible to read the docs on a phone
emilkrebs
added a commit
that referenced
this pull request
Oct 26, 2023
* fixed nested elements and scaling * remaned one function * fixed a renaming problem * Fix typo in getting-started grammar (#198) * Fix typo in getting-started grammar * Make code blocks vertically scrollable To make it possible to read the docs on a phone * Update Langium + Monaco Tutorials (#192) * update of langium + monaco tutorial * update generation in the web tutorial * Update to latest monaco-editor-wrapper and monaco-editor-react (#196) * Update to latest monaco-editor-wrapper and monaco-editor-react * Implemented review comments * fixed a renaming problem --------- Co-authored-by: Vit Gottwald <[email protected]> Co-authored-by: Benjamin Friedman Wilson <[email protected]> Co-authored-by: Kai Salmen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.