Decouple common azure connector settings from handlers' settings #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eneral azure connector settings - AzureSettings struct contains only general azure connector settings - message handlers' specific settings and flags (e.g.passthrough topics) moved to cmd/azure-connector/config.go file Signed-off-by: Stoyan Zoubev <[email protected]>
hristobojilov
requested changes
Oct 17, 2022
e-grigorov
suggested changes
Oct 19, 2022
- test method renamed - fixed a typo Signed-off-by: Stoyan Zoubev <[email protected]>
hristobojilov
approved these changes
Oct 19, 2022
These flags are specific for this concrete main i.e. if azure connector is reused with another main, they can be replaced. |
e-grigorov
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#19] Decouple common Azure connector settings from message handlers' settings
Signed-off-by: Stoyan Zoubev [email protected]