Decouple common Azure connector settings from message handlers' settings #19
Comments
stoyan-zoubev
changed the title
stoyan-zoubev
added a commit
to SoftwareDefinedVehicle/kanto-azure-connector
that referenced
this issue
Oct 14, 2022
…eneral azure connector settings - AzureSettings struct contains only general azure connector settings - message handlers' specific settings and flags (e.g.passthrough topics) moved to cmd/azure-connector/config.go file Signed-off-by: Stoyan Zoubev <[email protected]>
e-grigorov
pushed a commit
that referenced
this issue
Oct 24, 2022
[#19] Decouple common Azure connector settings from message handlers' settings - AzureSettings struct contains only general azure connector settings - message handlers' specific settings and flags (e.g.passthrough topics) moved to cmd/azure-connector/config.go file Signed-off-by: Stoyan Zoubev <[email protected]>
Repository owner
moved this from In Review
to Done
in Eclipse Kanto
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue relates to #17 Improve message handler pluggability.
Some message handler specific settings are directly put into the
config.AzureSettingsstructure -MessageMapperConfig,AllowedLocalTopicsList,AllowedCloudMessageTypesList.These settings are only for the message handling and they have nothing to do with the rest of the common settings, needed to establish and maintain connections toward Azure IoT Hub, local brokers, log settings, etc. Additionally, these apply only for the concrete binary of the Kanto azure connector, the default one will need settings for its passthrough handlers, while extended/customized binaries may add new handler settings and may not need any of the default passthrough settings.
As the #17 proposal is to move full message handler instantiation control to
mainpackage, then it is better to move message handlers settings there too. E.g. define a new settings structure, that holds all the settings for the message handlers that will be created and extend the commonconfig.AzureSettingswith it; respectively the message handler flags should be defined and processed bymainpackage too.The text was updated successfully, but these errors were encountered: