Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes testBug519493_003 - module binding on class symbol #612

Open
wants to merge 866 commits into
base: dom-with-javac
Choose a base branch
from
Open

Fixes testBug519493_003 - module binding on class symbol #612

wants to merge 866 commits into from

Conversation

robstryker
Copy link

No description provided.

@mickaelistria
Copy link

This seems to introduce some new failures:

diff head-sorted robs-sorted 
797a798,808
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0002
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0003
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0004
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0005
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0006
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0007
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0008
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingCopyTest.test0009
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingRemoveTest.test0004
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingRemoveTest.test0006
>     Build and Test / org.eclipse.jdt.core.tests.rewrite.modifying.ASTRewritingModifyingRemoveTest.test0009
1354c1365
<     javac specific tests / org.eclipse.jdt.core.tests.dom.ASTConverter9Test.testBug519493_003
---
>     javac specific tests / org.eclipse.jdt.core.tests.dom.ASTConverter9Test.testBug519493_002

Let's first rebase to check whether those vanish.

@robstryker
Copy link
Author

When I run these tests locally, I'm not seeing much of a difference at all between with the PR or without the PR. This is very strange.

@mickaelistria mickaelistria force-pushed the dom-with-javac branch 2 times, most recently from c02519d to e65aeb8 Compare July 25, 2024 22:05
@robstryker
Copy link
Author

Rebased, Will investigate what it does to tests.

@mickaelistria mickaelistria force-pushed the dom-with-javac branch 2 times, most recently from 13a7ce9 to 911e4b3 Compare September 10, 2024 08:43
@mickaelistria mickaelistria force-pushed the dom-with-javac branch 3 times, most recently from 16bd705 to 9fb5696 Compare September 25, 2024 06:20
@mickaelistria mickaelistria force-pushed the dom-with-javac branch 2 times, most recently from 7f5c20a to 87832d6 Compare December 6, 2024 13:52
@mickaelistria mickaelistria force-pushed the dom-with-javac branch 3 times, most recently from 630ab89 to 141942c Compare January 10, 2025 09:11
datho7561 and others added 2 commits January 15, 2025 16:56
@datho7561
Fix AST conversion error when handling type in array dims
059c507 
eg. preserve the `m[]` in the AST in the following case,
(despite the fact that it's invalid),
since javac does.

```java
int[] foo = new int[m[]];
```

Signed-off-by: David Thompson <[email protected]>
@mickaelistria
De-duplicate test-on-javase23 profile
20afc1a
akurtakov and others added 17 commits January 15, 2025 16:56
@akurtakov
Remove unused methods from JavacBindingResolver
27a8ebe
@datho7561
Error IDs for problems unique to javac
eb6354c 
This causes 6 regerssions because 'possible this escape' is now
reported.

Signed-off-by: David Thompson <[email protected]>
@mickaelistria
Add NON_STATIC to relevance
5f67080
@mickaelistria
Do not insert classname for static methods inside expression
ef52571
@datho7561
Fixes to Javadoc completion
2f0a1b4 
- fix a bug related to ordering of tag names
- get `@param| ` completion to work as expected
- use `DOMCompletionUtil.findParent` instead of only checking the direct
  parent when calculating the node to use as context for completion
  (in the case of nodes within `Javadoc`)
- split out `MemberRef` and `MethodRef` to their own completion cases
  - for now these are stubs
- move the logic for type completion for `@see` and `@link` under the
  TagElement section, as it should be handled differently than the
  "default completion":
  - improve handling of qualified references
  - for the time being, suggest nothing when completing a type from a
    specific module.
    i.e. `@see java.base/java.util.|` no longer gives any results.

Signed-off-by: David Thompson <[email protected]>
@akurtakov
Add java.base/sun.nio.ch=ALL-UNNAMED to arguments
5227ce6 
Also needed but missed.
@datho7561
Implement completion for field ref in Javadoc
28c3d2d 
Note that there are two code paths: one through `MemberRef` and
another through an `@link` or `@see` `TagElement`.
This is because the AST conversion tests expect the following to be a
`TextElement` instead of a `MemberRef`:

```java
/**
 * @see MyClass#
 */
```

(and also:)

```java
/**
 * @see #
 */
```

However, the completion tests expect completion for MyClass' members to
work in this case.

Fixes eclipse-jdt#1103

Signed-off-by: David Thompson <[email protected]>
@mickaelistria
Some work on type completion
c3daab7 
* Type parameters
* Annotations
* Relevance
@mickaelistria
Improvements to completion
4592aa2 
* Support type restriction for SwitchCase
* Support for QualifiedType
* Fix CompletionContext.getExpectedTypesSignatures()
@mickaelistria
Improve relevance computation for annotation without @target
22943f0
@mickaelistria
Improve some import static type completion
62397eb
@mickaelistria
Work on completion with static import
ce98ae6 
* Return more proposals
* Do no repeat extra import in proposals
@datho7561
Completion for method references in javadoc
4e6b822 
- Fixes for the relevance numbers for methods in javadoc
- Suggest constructors (including the default constructor) in `@see` and
  `@link`
- Do not show completion when completing parameter name in method
  reference in Javadoc
- when referencing a method from Javadoc,
  and the cursor is in the method parameters,
  specifically right after a `(` or `,`,
  complete the entire method signature

This should fix 37 test cases

Signed-off-by: David Thompson <[email protected]>
@akurtakov
Record junit issues and warn on increase
dd584cc
@mickaelistria
More support for annotation value names
3e2c9d4
@mickaelistria
Improve support for completing enum constants in switch case
d7e8241
@akurtakov
Publish all issues in Jenkins
1901a3c
@datho7561 datho7561 force-pushed the dom-with-javac branch 2 times, most recently from a1bf22f to 0b6fd1c Compare January 27, 2025 15:37
@robstryker robstryker force-pushed the dom-with-javac branch 2 times, most recently from 838c386 to 40594bf Compare January 31, 2025 18:15
@mickaelistria mickaelistria force-pushed the dom-with-javac branch 2 times, most recently from c906abc to b53a413 Compare February 7, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@robstryker robstryker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@robstryker @mickaelistria @datho7561 @testforstephen @snjeza @akurtakov @rgrunber