Move the DOM-based search into the javac bundle #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickaelistria
force-pushed
the
dom-with-javac
branch
from
c906abc to
b53a413
Compare
|
That can make a lot of sense for now. |
|
Extension point is already submitted upstream but not yet merged. This branch will likely need a careful application when being merged, so please (when appropriate) just give your approval but do not merge it yourself. I will handle it. This PR is slightly different from the upstream one, and we may need to reorder the commits so as to minimize the affects. |
robstryker
force-pushed
the
moveDOMSearchToJavacBundle
branch
from
4fd4717 to
2ce4b23
Compare
Signed-off-by: Rob Stryker <[email protected]>
robstryker
force-pushed
the
dom-with-javac
branch
from
9fb5c87 to
d568f49
Compare
robstryker
force-pushed
the
moveDOMSearchToJavacBundle
branch
2 times, most recently
from
e05d5af to
77abe2a
Compare
Extra strategy in MatchLocator to use DOM, and tweaks in various Locators to properly handle DOM. Tests in JavaSearchTests help a lot (currently ~130/270 passing) It basically clones and adapt some methods and adapt them to DOM, A new flag is introduced to decide the strategy. Done-ish (often with remaining issues) * FieldLocator * LocalVariableLocator * MethodLocator * SuperTypeReferenceLocator * TypeDeclarationLocator * TypeParameterLocator * TypeReferenceLocator TODO: * AndLocator * ModuleLocator * PackageDeclarationLocator * PackageReferenceLocator * OrLocator * VariableLocator Make some match locator work with DOM Fix NPE, convert 4 errors to fails Signed-off-by: Rob Stryker <[email protected]> Handle match files in the order they arrived Signed-off-by: Rob Stryker <[email protected]> Fix testBug251827b and 5 others - import declarations java element must be found Signed-off-by: Rob Stryker <[email protected]> Move the DOM-based search into the javac bundle Signed-off-by: Rob Stryker <[email protected]> Cleanup Signed-off-by: Rob Stryker <[email protected]>
robstryker
force-pushed
the
moveDOMSearchToJavacBundle
branch
from
77abe2a to
8b6d476
Compare
Signed-off-by: Rob Stryker <[email protected]>
|
This was a bit messy, but I ended up removing the following commits from history:
Then I cherry-picked them as part of this PR, and then I squashed some together. So this PR included the commit still up for submission at jdt.core main repo (extension point) and the next 6 commits rebased, cleaned up, and squashed. So... that... looks good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.