Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre JLS 8 convertions #1216

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

akurtakov
Copy link

Not needed as neither Javac nor ECJ nor JDT makes use of anything pre Java 8 nowadays.
VariableDeclaration.extraArrayDeclarataion is not supported in Java 8+ but was used without guards which shouldn't have happened.

@akurtakov akurtakov force-pushed the dom-with-javac branch 3 times, most recently from bad987d to 5f030b6 Compare February 5, 2025 14:28
@akurtakov akurtakov force-pushed the dom-with-javac branch 2 times, most recently from f84f50e to 9cb86c6 Compare February 7, 2025 10:43
Not needed as neither Javac nor ECJ nor JDT makes use of anything pre
Java 8 nowadays.
VariableDeclaration.extraArrayDeclarataion is not supported in Java 8+
but was used without guards which shouldn't have happened.
Copy link

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks, Alex!

@datho7561 datho7561 merged commit 4932b61 into eclipse-jdtls:dom-with-javac Feb 7, 2025
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants