Fix completion for static import duplicates import #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2aa2631. Improve Lombok support by running analysis less greedily
This one deals mostly with explicit this param. Signed-off-by: David Thompson <[email protected]>
requires 1 VM arg per line
eg. preserve the `m[]` in the AST in the following case, (despite the fact that it's invalid), since javac does. ```java int[] foo = new int[m[]]; ``` Signed-off-by: David Thompson <[email protected]>
Skip in case we're running tests to remain compatible with JDT
…n count Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Javac sometimes add virtual nodes to the tree (usually with endPos == -1). Ignore then when computing diagnostic position.
Log instead
This reverts commit 13618d9 as upstream as applied similar/better change when merging Java 23 support
* Treat DCRawText as raw text (don't both splitting lines) * Some fixes in TagElement range correction
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
…ings is set to true Signed-off-by: Rob Stryker <[email protected]>
…r in parsing or resolution Signed-off-by: Rob Stryker <[email protected]>
Signed-off-by: Rob Stryker <[email protected]>
…tion Signed-off-by: Rob Stryker <[email protected]>
- fix a bug related to ordering of tag names
- get `@param| ` completion to work as expected
- use `DOMCompletionUtil.findParent` instead of only checking the direct
parent when calculating the node to use as context for completion
(in the case of nodes within `Javadoc`)
- split out `MemberRef` and `MethodRef` to their own completion cases
- for now these are stubs
- move the logic for type completion for `@see` and `@link` under the
TagElement section, as it should be handled differently than the
"default completion":
- improve handling of qualified references
- for the time being, suggest nothing when completing a type from a
specific module.
i.e. `@see java.base/java.util.|` no longer gives any results.
Signed-off-by: David Thompson <[email protected]>
Also needed but missed.
Note that there are two code paths: one through `MemberRef` and another through an `@link` or `@see` `TagElement`. This is because the AST conversion tests expect the following to be a `TextElement` instead of a `MemberRef`: ```java /** * @see MyClass# */ ``` (and also:) ```java /** * @see # */ ``` However, the completion tests expect completion for MyClass' members to work in this case. Fixes eclipse-jdt#1103 Signed-off-by: David Thompson <[email protected]>
* Type parameters * Annotations * Relevance
* Support type restriction for SwitchCase * Support for QualifiedType * Fix CompletionContext.getExpectedTypesSignatures()
* Return more proposals * Do no repeat extra import in proposals
- Fixes for the relevance numbers for methods in javadoc - Suggest constructors (including the default constructor) in `@see` and `@link` - Do not show completion when completing parameter name in method reference in Javadoc - when referencing a method from Javadoc, and the cursor is in the method parameters, specifically right after a `(` or `,`, complete the entire method signature This should fix 37 test cases Signed-off-by: David Thompson <[email protected]>
robstryker
force-pushed
the
dom-with-javac
branch
3 times, most recently
from
9c17bb6 to
4516c31
Compare
datho7561
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
a1bf22f to
0b6fd1c
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
from
7ad387c to
c52dfb2
Compare
datho7561
force-pushed
the
dom-with-javac
branch
from
c52dfb2 to
76e9c9c
Compare
robstryker
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
838c386 to
40594bf
Compare
datho7561
force-pushed
the
dom-with-javac
branch
from
15d0bf3 to
811bae7
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
c906abc to
b53a413
Compare
robstryker
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
08ec5cf to
10fe71a
Compare
mickaelistria
force-pushed
the
dom-with-javac
branch
2 times, most recently
from
c2b9da2 to
c640bdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.