Improve the pattern matching refactoring #1964
Open
+193
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the smart casting can be used in deeper parts of the AST, not just directly as the first expression, which is surprisingly common.
|
Could you please have a look on it @jjohnstn ? I think you are the most familiar with this code that I tried to change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the smart casting can be used in deeper parts of the AST, not just directly as the first expression, which is surprisingly common.
What it does
Improve the logic which tries to locate casts that can be eliminated with pattern matching
How to test
Run the refactoring on a bigger codebase
Author checklist