Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2301 32 bit MVP #2335

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Aug 22, 2024

Notes for Reviewer

This PR add initial 32 bit support for iceoryx. Mixed mode with 64 bit application does not yet work but will be part of the next PR.

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido force-pushed the iox-2301-32-bit-mvp branch 7 times, most recently from 571ef1d to 8a62708 Compare August 22, 2024 20:04
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 78.75000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 78.23%. Comparing base (5bca9a4) to head (72a8dfd).
Report is 11 commits behind head on main.

Files Patch % Lines
tools/introspection/source/introspection_app.cpp 0.00% 10 Missing ⚠️
iceoryx_posh/experimental/source/node.cpp 0.00% 2 Missing ⚠️
...hoofs/memory/include/iox/detail/static_storage.inl 0.00% 0 Missing and 1 partial ⚠️
...ofs/posix/ipc/include/iox/detail/message_queue.inl 88.88% 1 Missing ⚠️
...rnal/roudi/introspection/mempool_introspection.inl 0.00% 1 Missing ⚠️
iceoryx_posh/source/roudi/roudi.cpp 0.00% 1 Missing ⚠️
iceoryx_posh/source/runtime/posh_runtime.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2335   +/-   ##
=======================================
  Coverage   78.22%   78.23%           
=======================================
  Files         433      433           
  Lines       16034    16041    +7     
  Branches     2302     2301    -1     
=======================================
+ Hits        12543    12549    +6     
- Misses       2644     2647    +3     
+ Partials      847      845    -2     
Flag Coverage Δ
unittests 78.05% <78.75%> (+<0.01%) ⬆️
unittests_timing 15.04% <23.75%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
iceoryx_binding_c/source/c_runtime.cpp 84.61% <100.00%> (ø)
iceoryx_binding_c/source/c_subscriber.cpp 92.40% <100.00%> (+1.49%) ⬆️
iceoryx_hoofs/cli/source/command_line_parser.cpp 95.34% <100.00%> (ø)
...oryx_hoofs/container/include/iox/detail/vector.inl 96.31% <100.00%> (ø)
...ofs/memory/include/iox/detail/relative_pointer.inl 96.38% <100.00%> (ø)
iceoryx_hoofs/memory/include/iox/memory.hpp 100.00% <ø> (ø)
...oryx_hoofs/memory/include/iox/relative_pointer.hpp 100.00% <ø> (ø)
iceoryx_hoofs/memory/source/memory.cpp 63.63% <100.00%> (ø)
iceoryx_hoofs/posix/filesystem/source/file.cpp 33.33% <100.00%> (+1.04%) ⬆️
...osix/ipc/include/iox/detail/unix_domain_socket.inl 83.05% <100.00%> (ø)
... and 18 more

... and 1 file with indirect coverage changes

@elBoberido elBoberido force-pushed the iox-2301-32-bit-mvp branch 3 times, most recently from 9bfdaa8 to ef3b6fa Compare August 22, 2024 21:54
@elBoberido elBoberido force-pushed the iox-2301-32-bit-mvp branch from ef3b6fa to 1a15b22 Compare August 22, 2024 23:46
@elBoberido elBoberido force-pushed the iox-2301-32-bit-mvp branch from 1a15b22 to 3d645db Compare August 23, 2024 00:09
@elBoberido elBoberido requested review from elfenpiff and removed request for elfenpiff August 23, 2024 00:12
@elBoberido elBoberido force-pushed the iox-2301-32-bit-mvp branch 3 times, most recently from 2826b2b to 1d13884 Compare August 23, 2024 03:04
@elBoberido elBoberido requested a review from elfenpiff August 23, 2024 03:04
@elBoberido elBoberido self-assigned this Aug 23, 2024
@elBoberido elBoberido changed the title [WIP] iox-#2301 32 bit MVP iox-#2301 32 bit MVP Aug 23, 2024
@elBoberido elBoberido force-pushed the iox-2301-32-bit-mvp branch from 1d13884 to 80da8ce Compare August 23, 2024 03:26
@elBoberido elBoberido force-pushed the iox-2301-32-bit-mvp branch from 80da8ce to 72a8dfd Compare August 23, 2024 03:52
@elBoberido elBoberido merged commit 9f04853 into eclipse-iceoryx:main Aug 27, 2024
26 checks passed
@elBoberido elBoberido deleted the iox-2301-32-bit-mvp branch August 27, 2024 12:38
@elBoberido elBoberido linked an issue Aug 27, 2024 that may be closed by this pull request
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

32-Bit Support
2 participants