Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#2305 Fix CI badge links and add iceoryx2 reference to the readme #2306

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jun 21, 2024

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Checklist for the PR Reviewer

  • Consider a second reviewer for complex new features or larger refactorings
  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido requested a review from elfenpiff June 21, 2024 16:18
@elBoberido elBoberido self-assigned this Jun 21, 2024
@elBoberido elBoberido force-pushed the iox-2305-fix-badge-and-add-iceoryx2-reference-to-readme branch from 548b4aa to 4e25537 Compare June 21, 2024 16:20
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.06%. Comparing base (7b0dabe) to head (4e25537).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2306      +/-   ##
==========================================
- Coverage   78.07%   78.06%   -0.01%     
==========================================
  Files         432      432              
  Lines       15920    15920              
  Branches     2303     2303              
==========================================
- Hits        12429    12428       -1     
  Misses       2644     2644              
- Partials      847      848       +1     
Flag Coverage Δ
unittests 77.88% <ø> (-0.01%) ⬇️
unittests_timing 14.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@elBoberido elBoberido merged commit d0b16dd into eclipse-iceoryx:main Jun 21, 2024
25 checks passed
@elBoberido elBoberido deleted the iox-2305-fix-badge-and-add-iceoryx2-reference-to-readme branch June 21, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants