-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#1361 Use shared memory for process alive detection #2056
iox-#1361 Use shared memory for process alive detection #2056
Conversation
@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @elfenpiff @budrus feel free to add yourself as reviewer |
aae1632
to
d43405d
Compare
6724ceb
to
785714a
Compare
785714a
to
9cdf381
Compare
c34ca20
to
9cdf381
Compare
d43405d
to
2fdbb96
Compare
9cdf381
to
d725812
Compare
2fdbb96
to
f20df53
Compare
d725812
to
c5bd28b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2056 +/- ##
==========================================
+ Coverage 80.10% 80.12% +0.02%
==========================================
Files 416 417 +1
Lines 16026 16059 +33
Branches 2250 2255 +5
==========================================
+ Hits 12837 12867 +30
- Misses 2384 2385 +1
- Partials 805 807 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f20df53
to
a7f4165
Compare
c5bd28b
to
2f92bb0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just minor things.
…AssignmentTracker'
b1c74a1
to
dda2e7f
Compare
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)iceoryx_hoofs
are added to./clang-tidy-diff-scans.txt
Notes for Reviewer
This PR refactors the process alive detection by moving it from an IPC message to a timestamp in the shared memory. It is still not optimal but helps with #2040 and should prevent #1374.
Ideally the process alive detection should not depend on a free running thread to update a value but either on the frequency of the actual sent messages or actual crash detection to prevent
RouDi
from killing applications which are stopped in a debugger.Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References