Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disabling OCSP integration tests #3622

Merged
merged 1 commit into from
Apr 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.DisabledIfSystemProperty;
import org.junit.jupiter.api.extension.ExtendWith;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.testcontainers.containers.GenericContainer;
import org.testcontainers.containers.output.Slf4jLogConsumer;
import org.testcontainers.containers.wait.strategy.Wait;
import org.testcontainers.images.builder.ImageFromDockerfile;
import org.testcontainers.junit.jupiter.Testcontainers;

import io.vertx.core.Vertx;
import io.vertx.core.net.SelfSignedCertificate;
Expand All @@ -52,7 +52,7 @@
* tested against running instance of OCSP responder which is set up using openssl tool running in Testcontainers.
*
*/
@Testcontainers
@DisabledIfSystemProperty(named = "hono.skipDockerTests", matches = "true")
@ExtendWith(VertxExtension.class)
class OCSPIntegrationTest {
private static final Logger LOG = LoggerFactory.getLogger(OCSPIntegrationTest.class);
Expand All @@ -75,7 +75,7 @@ class OCSPIntegrationTest {
/**
* Load certificates from file system and initialize OCSP responder container.
*/
@SuppressWarnings({"rawtypes", "unchecked"})
@SuppressWarnings({"rawtypes", "unchecked", "resource"})
@BeforeAll
static void setUpAll() {
validCertificate = loadCertificate("target/certs/device-4711-cert.pem");
Expand Down
1 change: 1 addition & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,7 @@
<systemPropertyVariables>
<!-- use Base64 encoder/decoder that is compatible with vert.x 3 -->
<vertx.json.base64>legacy</vertx.json.base64>
<hono.skipDockerTests>${skipDockerTests}</hono.skipDockerTests>
</systemPropertyVariables>
<properties>
<configurationParameters>
Expand Down
Loading