Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commit requirements in Contributing page #3554

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

calohmn
Copy link
Contributor

@calohmn calohmn commented Sep 29, 2023

Removing the 'Signed-off-by' requirement as it isn't listed in the Eclipse Project Handbook anymore.

See the corresponding change in the org.eclipse.dash.handbook repo here.

@calohmn calohmn added the website issues regarding the overall look & feel and structure of the website label Sep 29, 2023
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point 6 in the Making your Changes list (Do not forget to add yourself or your organization to the copyright holder list in the NOTICE file ...) also doesn't seem necessary anymore.
See https://gitlab.eclipse.org/eclipse/technology/dash/org.eclipse.dash.handbook/-/issues/96
and the example NOTICE file here.
@sophokles73 Shall this be changed here as well, or would you rather keep the list in the NOTICE file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the time being, we should keep it because I do not really see how we could achieve the same results by means of just the Git commit log when authors use a (private) email address that give no clue regarding their affiliation. I will discuss this with the Eclipse Foundation, though ...

Removing the 'Signed-off-by' requirement as it isn't listed in the
Eclipse Project Handbook anymore.
@calohmn calohmn force-pushed the PR/update_contributing_info branch from 1f493b8 to 2431164 Compare October 3, 2023 06:28
@sophokles73 sophokles73 added this to the 2.5.0 milestone Oct 4, 2023
Copy link
Contributor

@sophokles73 sophokles73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :-)

LGTM

@calohmn calohmn merged commit f15bc59 into eclipse-hono:master Oct 6, 2023
6 checks passed
@calohmn calohmn deleted the PR/update_contributing_info branch October 6, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website issues regarding the overall look & feel and structure of the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants