Add Maven 3.8.7 wrapper scripts #3533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fair enough... I just tried building again with a globally installed Maven 3.9.4 and it worked for me. Personally I prefer to have project "self contained" if possible and I like having the ability if needed to run one version of Maven for project A and another for project B. Also as I mentioned, adding the wrapper to the project is a statement that this version of Maven should work with this project, preventing obscure troubleshooting for people who accidentally have installed a pre-release of the build tool. But no worries. I'm not sad ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if there are some good reasons for not having the Maven wrapper scripts but I'm creating a PR for it in case the only reason is just that nobody has done it yet.
I personally like having them as it allows pinning Maven to a version that is known to work (for example, the current latest version of Maven, 3.9.4, does not seem to work). It also means that people don't need to have Maven installed "globally".