Refactor unsafe code in raw_jobs.rs for better memory safety #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A potential issue was present where the check to the pointed to memory was done independently to the cast to the Rust type. The check was meant to protect from casting memory in an invalid state, but did not protect from the memory being modified in between the check and the cast. This new version creates a copy on the stack _first_. This way, we can safely validate it and trust our own memory to still be valid when we call `assume_init()`.
SCingolani
force-pushed
the
saci/fix-from-raw
branch
from
7811cae
to
4c6d073
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A potential issue was present where the check to the pointed to memory was done independently to the cast to the Rust type. The check was meant to protect from casting memory in an invalid state, but did not protect from the memory being modified in between the check and the cast.
This new version creates a copy on the stack first. This way, we can safely validate it and trust our own memory to still be valid when we call
assume_init().