Lombok Usage Improvements

Signed-off-by: Avgustin Marinov <[email protected]>
eclipse-hawkbit · Jan 10, 2025 · 837af61 · 837af61
1 parent b3f517a
commit 837af61
Show file tree

Hide file tree

Showing 72 changed files with 137 additions and 242 deletions.
diff --git a/hawkbit-ddi/hawkbit-ddi-api/src/main/java/org/eclipse/hawkbit/ddi/json/model/DdiPolling.java b/hawkbit-ddi/hawkbit-ddi-api/src/main/java/org/eclipse/hawkbit/ddi/json/model/DdiPolling.java
@@ -14,7 +14,6 @@
 import com.fasterxml.jackson.annotation.JsonInclude.Include;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import io.swagger.v3.oas.annotations.media.Schema;
-import lombok.AccessLevel;
 import lombok.EqualsAndHashCode;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
@@ -23,7 +22,7 @@
 /**
  * Polling interval for the SP target.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC)// needed for json create
+@NoArgsConstructor // needed for json create
 @Getter
 @EqualsAndHashCode
 @ToString

diff --git a/...rc/main/java/org/eclipse/hawkbit/repository/event/remote/CancelTargetAssignmentEvent.java b/...rc/main/java/org/eclipse/hawkbit/repository/event/remote/CancelTargetAssignmentEvent.java
@@ -12,14 +12,13 @@
 import java.io.Serial;
 import java.util.List;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.model.Action;
 
 /**
  * Event that gets sent when the assignment of a distribution set to a target gets canceled.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class CancelTargetAssignmentEvent extends AbstractAssignmentEvent {
 
     @Serial

diff --git a/...rc/main/java/org/eclipse/hawkbit/repository/event/remote/DistributionSetDeletedEvent.java b/...rc/main/java/org/eclipse/hawkbit/repository/event/remote/DistributionSetDeletedEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityDeletedEvent;
 import org.eclipse.hawkbit.repository.model.DistributionSet;
@@ -20,7 +19,7 @@
 /**
  * Defines the remote event for deletion of {@link DistributionSet}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class DistributionSetDeletedEvent extends RemoteIdEvent implements EntityDeletedEvent {
 
     @Serial

diff --git a/...main/java/org/eclipse/hawkbit/repository/event/remote/DistributionSetTagDeletedEvent.java b/...main/java/org/eclipse/hawkbit/repository/event/remote/DistributionSetTagDeletedEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityDeletedEvent;
 import org.eclipse.hawkbit.repository.model.DistributionSetTag;
@@ -20,7 +19,7 @@
 /**
  * Defines the the remote event of delete a {@link DistributionSetTag}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class DistributionSetTagDeletedEvent extends RemoteIdEvent implements EntityDeletedEvent {
 
     @Serial

diff --git a/...ain/java/org/eclipse/hawkbit/repository/event/remote/DistributionSetTypeDeletedEvent.java b/...ain/java/org/eclipse/hawkbit/repository/event/remote/DistributionSetTypeDeletedEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityDeletedEvent;
 import org.eclipse.hawkbit.repository.model.DistributionSetType;
@@ -20,7 +19,7 @@
 /**
  * Defines the remote event of deleting a {@link DistributionSetType}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class DistributionSetTypeDeletedEvent extends RemoteIdEvent implements EntityDeletedEvent {
 
     @Serial

diff --git a/...-api/src/main/java/org/eclipse/hawkbit/repository/event/remote/DownloadProgressEvent.java b/...-api/src/main/java/org/eclipse/hawkbit/repository/event/remote/DownloadProgressEvent.java
@@ -11,15 +11,14 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.model.ActionStatus;
 
 /**
  * TenantAwareEvent that contains an updated download progress for a given
  * ActionStatus that was written for a download request.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class DownloadProgressEvent extends RemoteTenantAwareEvent {
 
     @Serial

diff --git a/...api/src/main/java/org/eclipse/hawkbit/repository/event/remote/MultiActionAssignEvent.java b/...api/src/main/java/org/eclipse/hawkbit/repository/event/remote/MultiActionAssignEvent.java
@@ -12,7 +12,6 @@
 import java.io.Serial;
 import java.util.List;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.model.Action;
 
@@ -23,7 +22,7 @@
  * actionIds containing the identifiers of the affected actions
  * as payload. This event is only published in case of an assignment.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC)
+@NoArgsConstructor
 public class MultiActionAssignEvent extends MultiActionEvent {
 
     @Serial

diff --git a/...api/src/main/java/org/eclipse/hawkbit/repository/event/remote/MultiActionCancelEvent.java b/...api/src/main/java/org/eclipse/hawkbit/repository/event/remote/MultiActionCancelEvent.java
@@ -12,7 +12,6 @@
 import java.io.Serial;
 import java.util.List;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.model.Action;
 
@@ -23,7 +22,7 @@
  * actionIds containing the identifiers of the affected actions
  * as payload. This event is only published in case of an cancellation.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class MultiActionCancelEvent extends MultiActionEvent {
 
     @Serial

diff --git a/...ry-api/src/main/java/org/eclipse/hawkbit/repository/event/remote/RolloutDeletedEvent.java b/...ry-api/src/main/java/org/eclipse/hawkbit/repository/event/remote/RolloutDeletedEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityDeletedEvent;
 import org.eclipse.hawkbit.repository.model.Rollout;
@@ -20,7 +19,7 @@
 /**
  * Defines the remote event of deleting a {@link Rollout}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class RolloutDeletedEvent extends RemoteIdEvent implements EntityDeletedEvent {
 
     @Serial

diff --git a/...i/src/main/java/org/eclipse/hawkbit/repository/event/remote/RolloutGroupDeletedEvent.java b/...i/src/main/java/org/eclipse/hawkbit/repository/event/remote/RolloutGroupDeletedEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityDeletedEvent;
 import org.eclipse.hawkbit.repository.model.RolloutGroup;
@@ -20,7 +19,7 @@
 /**
  * Defines the remote event of deleting a {@link RolloutGroup}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class RolloutGroupDeletedEvent extends RemoteIdEvent implements EntityDeletedEvent {
 
     @Serial

diff --git a/...ry-api/src/main/java/org/eclipse/hawkbit/repository/event/remote/RolloutStoppedEvent.java b/...ry-api/src/main/java/org/eclipse/hawkbit/repository/event/remote/RolloutStoppedEvent.java
@@ -12,7 +12,6 @@
 import java.io.Serial;
 import java.util.Collection;
 
-import lombok.AccessLevel;
 import lombok.Data;
 import lombok.EqualsAndHashCode;
 import lombok.NoArgsConstructor;
@@ -23,7 +22,7 @@
  * Event that is published when a rollout is stopped due to invalidation of a
  * {@link DistributionSet}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 @Data
 @EqualsAndHashCode(callSuper = true)
 @ToString(callSuper = true)

diff --git a/...src/main/java/org/eclipse/hawkbit/repository/event/remote/SoftwareModuleDeletedEvent.java b/...src/main/java/org/eclipse/hawkbit/repository/event/remote/SoftwareModuleDeletedEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityDeletedEvent;
 import org.eclipse.hawkbit.repository.model.SoftwareModule;
@@ -20,7 +19,7 @@
 /**
  * Defines the remote event of deleting a {@link SoftwareModule}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class SoftwareModuleDeletedEvent extends RemoteIdEvent implements EntityDeletedEvent {
 
     @Serial

diff --git a/...main/java/org/eclipse/hawkbit/repository/event/remote/SoftwareModuleTypeDeletedEvent.java b/...main/java/org/eclipse/hawkbit/repository/event/remote/SoftwareModuleTypeDeletedEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityDeletedEvent;
 import org.eclipse.hawkbit.repository.model.SoftwareModuleType;
@@ -20,7 +19,7 @@
 /**
  * Defines the remote event of deleting a {@link SoftwareModuleType}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class SoftwareModuleTypeDeletedEvent extends RemoteIdEvent implements EntityDeletedEvent {
 
     @Serial

diff --git a/...main/java/org/eclipse/hawkbit/repository/event/remote/TargetAttributesRequestedEvent.java b/...main/java/org/eclipse/hawkbit/repository/event/remote/TargetAttributesRequestedEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.EqualsAndHashCode;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
@@ -22,7 +21,7 @@
 /**
  * Defines the remote event of triggering attribute updates of a {@link Target}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 @Getter
 @EqualsAndHashCode(callSuper = true)
 @ToString(callSuper = true)

diff --git a/...ory-api/src/main/java/org/eclipse/hawkbit/repository/event/remote/TargetDeletedEvent.java b/...ory-api/src/main/java/org/eclipse/hawkbit/repository/event/remote/TargetDeletedEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.EqualsAndHashCode;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
@@ -23,7 +22,7 @@
 /**
  * Defines the remote event of deleting a {@link Target}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 @Getter
 @EqualsAndHashCode(callSuper = true)
 @ToString(callSuper = true)

diff --git a/.../main/java/org/eclipse/hawkbit/repository/event/remote/TargetFilterQueryDeletedEvent.java b/.../main/java/org/eclipse/hawkbit/repository/event/remote/TargetFilterQueryDeletedEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityDeletedEvent;
 import org.eclipse.hawkbit.repository.model.TargetFilterQuery;
@@ -20,7 +19,7 @@
 /**
  * Defines the remote event of deleting a {@link TargetFilterQuery}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class TargetFilterQueryDeletedEvent extends RemoteIdEvent implements EntityDeletedEvent {
 
     @Serial

diff --git a/...sitory-api/src/main/java/org/eclipse/hawkbit/repository/event/remote/TargetPollEvent.java b/...sitory-api/src/main/java/org/eclipse/hawkbit/repository/event/remote/TargetPollEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.EqualsAndHashCode;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
@@ -21,7 +20,7 @@
 /**
  * Event is sent in case a target polls either through DDI or DMF.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 @Getter
 @EqualsAndHashCode(callSuper = true)
 @ToString(callSuper = true)

diff --git a/...-api/src/main/java/org/eclipse/hawkbit/repository/event/remote/TargetTagDeletedEvent.java b/...-api/src/main/java/org/eclipse/hawkbit/repository/event/remote/TargetTagDeletedEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityDeletedEvent;
 import org.eclipse.hawkbit.repository.model.TargetTag;
@@ -20,7 +19,7 @@
 /**
  * Defines the remote event of delete a {@link TargetTag}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class TargetTagDeletedEvent extends RemoteIdEvent implements EntityDeletedEvent {
 
     @Serial

diff --git a/...api/src/main/java/org/eclipse/hawkbit/repository/event/remote/TargetTypeDeletedEvent.java b/...api/src/main/java/org/eclipse/hawkbit/repository/event/remote/TargetTypeDeletedEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityDeletedEvent;
 import org.eclipse.hawkbit.repository.model.TargetType;
@@ -20,7 +19,7 @@
 /**
  * Defines the remote event of deleting a {@link TargetType}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class TargetTypeDeletedEvent extends RemoteIdEvent implements EntityDeletedEvent {
 
     @Serial

diff --git a/.../src/main/java/org/eclipse/hawkbit/repository/event/remote/entity/ActionCreatedEvent.java b/.../src/main/java/org/eclipse/hawkbit/repository/event/remote/entity/ActionCreatedEvent.java
@@ -11,15 +11,14 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityCreatedEvent;
 import org.eclipse.hawkbit.repository.model.Action;
 
 /**
  * Defines the remote event of creating a new {@link Action}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class ActionCreatedEvent extends AbstractActionEvent implements EntityCreatedEvent {
 
     @Serial

diff --git a/.../src/main/java/org/eclipse/hawkbit/repository/event/remote/entity/ActionUpdatedEvent.java b/.../src/main/java/org/eclipse/hawkbit/repository/event/remote/entity/ActionUpdatedEvent.java
@@ -11,15 +11,14 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityUpdatedEvent;
 import org.eclipse.hawkbit.repository.model.Action;
 
 /**
  * Defines the remote event of updated a {@link Action}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class ActionUpdatedEvent extends AbstractActionEvent implements EntityUpdatedEvent {
 
     @Serial

diff --git a/.../java/org/eclipse/hawkbit/repository/event/remote/entity/DistributionSetCreatedEvent.java b/.../java/org/eclipse/hawkbit/repository/event/remote/entity/DistributionSetCreatedEvent.java
@@ -11,15 +11,14 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityCreatedEvent;
 import org.eclipse.hawkbit.repository.model.DistributionSet;
 
 /**
  * Defines the remote of creating a new {@link DistributionSet}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class DistributionSetCreatedEvent extends RemoteEntityEvent<DistributionSet> implements EntityCreatedEvent {
 
     @Serial

diff --git a/...va/org/eclipse/hawkbit/repository/event/remote/entity/DistributionSetTagCreatedEvent.java b/...va/org/eclipse/hawkbit/repository/event/remote/entity/DistributionSetTagCreatedEvent.java
@@ -11,7 +11,6 @@
 
 import java.io.Serial;
 
-import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 import org.eclipse.hawkbit.repository.event.entity.EntityCreatedEvent;
 import org.eclipse.hawkbit.repository.model.DistributionSetTag;
@@ -20,7 +19,7 @@
  * Defines the {@link RemoteEntityEvent} for creation of a new
  * {@link DistributionSetTag}.
  */
-@NoArgsConstructor(access = AccessLevel.PUBLIC) // for serialization libs like jackson
+@NoArgsConstructor // for serialization libs like jackson
 public class DistributionSetTagCreatedEvent extends RemoteEntityEvent<DistributionSetTag> implements EntityCreatedEvent {
 
     @Serial