Clean Code for bundles/org.eclipse.equinox.registry

bundles/org.eclipse.equinox.registry/src/org/eclipse/core/internal/registry/BufferedRandomInputStream.java

@@ -21,7 +21,7 @@
 public class BufferedRandomInputStream extends InputStream {
 
 	private RandomAccessFile inputFile;
-	private String filePath; // Canonical path to the underlying file used for logging
+	private final String filePath; // Canonical path to the underlying file used for logging
 	private int buffer_size; // Current size of the buffer
 	private int buffer_pos; // Current read position in the buffer
 	/**

bundles/org.eclipse.equinox.registry/src/org/eclipse/core/internal/registry/Handle.java

@@ -26,7 +26,7 @@
 public abstract class Handle {
 	protected IObjectManager objectManager;
 
-	private int objectId;
+	private final int objectId;
 
 	public int getId() {
 		return objectId;

bundles/org.eclipse.equinox.registry/src/org/eclipse/core/internal/registry/osgi/Activator.java

@@ -40,7 +40,7 @@ public class Activator implements BundleActivator {
 	 */
 	private static final String STORAGE_DIR = "org.eclipse.core.runtime"; //$NON-NLS-1$
 
-	private Object masterRegistryKey = new Object();
+	private final Object masterRegistryKey = new Object();
 	private Object userRegistryKey = new Object();
 
 	private IExtensionRegistry defaultRegistry = null;

bundles/org.eclipse.equinox.registry/src/org/eclipse/core/internal/registry/spi/ConfigurationElementAttribute.java

@@ -39,14 +39,14 @@ public final class ConfigurationElementAttribute {
 	 * 
 	 * @see IConfigurationElement#getAttributeNames()
 	 */
-	private String name;
+	private final String name;
 
 	/**
 	 * Attribute value.
 	 * 
 	 * @see IConfigurationElement#getAttributeAsIs(String)
 	 */
-	private String value;
+	private final String value;
 
 	/**
 	 * Constructor.

bundles/org.eclipse.equinox.registry/src/org/eclipse/core/internal/registry/spi/ConfigurationElementDescription.java

@@ -41,28 +41,28 @@ public final class ConfigurationElementDescription {
 	 * 
 	 * @see IConfigurationElement#getName()
 	 */
-	private String name;
+	private final String name;
 
 	/**
 	 * Attributes of the configuration element.
 	 * 
 	 * @see IConfigurationElement#getAttribute(String)
 	 */
-	private ConfigurationElementAttribute[] attributes;
+	private final ConfigurationElementAttribute[] attributes;
 
 	/**
 	 * String value to be stored in this configuration element.
 	 * 
 	 * @see IConfigurationElement#getValue()
 	 */
-	private String value;
+	private final String value;
 
 	/**
 	 * Children of the configuration element.
 	 * 
 	 * @see IConfigurationElement#getChildren()
 	 */
-	private ConfigurationElementDescription[] children;
+	private final ConfigurationElementDescription[] children;
 
 	/**
 	 * Constructor.

bundles/org.eclipse.equinox.registry/src/org/eclipse/core/runtime/spi/RegistryContributor.java

@@ -40,12 +40,12 @@ public final class RegistryContributor implements IContributor {
 	 * Actual ID of the contributor (e.g., "12"). IDs are expected to be unique in
 	 * the workspace.
 	 */
-	private String actualContributorId;
+	private final String actualContributorId;
 
 	/**
 	 * Actual name of the contributor (e.g., "org.eclipse.core.runtime.fragment").
 	 */
-	private String actualContributorName;
+	private final String actualContributorName;
 
 	/**
 	 * ID associated with the entity "in charge" of the contributor (e.g., "1"). IDs