Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for bundles/org.eclipse.equinox.preferences #816

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

eclipse-equinox-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible

Copy link

github-actions bot commented Jan 29, 2025

Test Results

  669 files  +  223    669 suites  +223   1h 18m 4s ⏱️ + 27m 54s
2 223 tests ±    0  2 176 ✅ +    1   47 💤  -  1  0 ❌ ±0 
6 813 runs  +2 271  6 670 ✅ +2 224  143 💤 +47  0 ❌ ±0 

Results for commit 9c739b1. ± Comparison against base commit 7def4c5.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the clean-code/bundles/org.eclipse.equinox.preferences branch from 2299db5 to 15aebcf Compare January 29, 2025 11:31
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.preferences branch from 15aebcf to 9c739b1 Compare January 30, 2025 03:07
@laeubi laeubi merged commit fbdc0f0 into master Jan 30, 2025
28 of 29 checks passed
@laeubi laeubi deleted the clean-code/bundles/org.eclipse.equinox.preferences branch January 30, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants