Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean Code for bundles/org.eclipse.equinox.console #806

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Clean Code for bundles/org.eclipse.equinox.console #806

merged 1 commit into from
Jan 30, 2025

Conversation

eclipse-equinox-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2025 •
edited
Loading

Test Results

  669 files  +  223    669 suites  +223   1h 17m 57s ⏱️ + 27m 47s
2 223 tests ±    0  2 176 ✅ +    1   47 💤  -  1  0 ❌ ±0 
6 813 runs  +2 271  6 670 ✅ +2 224  143 💤 +47  0 ❌ ±0 

Results for commit 841c7ed. ± Comparison against base commit 7def4c5.

♻️ This comment has been updated with latest results.

@akurtakov akurtakov force-pushed the clean-code/bundles/org.eclipse.equinox.console branch from 21aaf4f to ddc7cfc Compare January 29, 2025 05:43
@eclipse-equinox-bot eclipse-equinox-bot force-pushed the clean-code/bundles/org.eclipse.equinox.console branch from ddc7cfc to 841c7ed Compare January 30, 2025 02:40
@laeubi laeubi merged commit 4f4cdcd into master Jan 30, 2025
28 of 29 checks passed
@laeubi laeubi deleted the clean-code/bundles/org.eclipse.equinox.console branch January 30, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eclipse-equinox-bot @laeubi