Perform clean code of bundles/org.eclipse.equinox.security.ui

bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/provisional/security/ui/X509CertificateViewDialog.java

@@ -28,9 +28,9 @@
 import org.eclipse.swt.widgets.*;
 
 public class X509CertificateViewDialog extends TitleAreaDialog {
-	private X509Certificate theCert;
+	private final X509Certificate theCert;
 	private static final DateFormat _df = DateFormat.getDateInstance(DateFormat.LONG);
-	private X500PrincipalHelper nameHelper = new X500PrincipalHelper();
+	private final X500PrincipalHelper nameHelper = new X500PrincipalHelper();
 
 	// We use the "bannerFont" for our bold font
 	private static Font boldFont = JFaceResources.getBannerFont();

bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/ConfirmationDialog.java

@@ -26,7 +26,7 @@ public class ConfirmationDialog extends TitleAreaDialog {
 	public static final int YES = 100;
 	public static final int NO = 101;
 
-	private Certificate cert;
+	private final Certificate cert;
 
 	public ConfirmationDialog(Shell parentShell, Certificate cert) {
 		super(parentShell);

bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/DefaultAuthorizationManager.java

@@ -27,7 +27,7 @@ public class DefaultAuthorizationManager extends AuthorizationManager {
 	boolean enabled = (null != Activator.getAuthorizationEngine());
 
 	private int currentStatus = IStatus.OK;
-	private boolean needsAttention = false;
+	private final boolean needsAttention = false;
 
 	public DefaultAuthorizationManager() {
 		currentStatus = enabled ? Activator.getAuthorizationEngine().getStatus() : IStatus.OK;

bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/SecurityStatusControl.java

@@ -45,7 +45,7 @@ public class SecurityStatusControl extends ControlContribution {
 	/* the default id for this Item */
 	private static final String ID = "org.eclipse.ui.securityStatus"; //$NON-NLS-1$
 
-	private IWorkbenchWindow window;
+	private final IWorkbenchWindow window;
 	private CLabel label;
 
 	private IconState currentState;

bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/X509CertificateAttribute.java

@@ -23,16 +23,16 @@ public class X509CertificateAttribute {
 	// Description of the field
 	// NOTE: This will show in the UI so it should be loaded from a translatable
 	// properties file.
-	private String fieldDescription;
+	private final String fieldDescription;
 
 	// A String representation of the value of the field. May have undergone some
 	// transformation to make it "pretty" in the UI
-	private String stringVal;
+	private final String stringVal;
 
 	// The raw data object from inside the certificate. Most likely whatever object
 	// the getter method
 	// for the field returns.
-	private Object rawValue;
+	private final Object rawValue;
 
 	public X509CertificateAttribute(String propDescription, String StringVal, Object objValue) {
 		super();

bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/X509CertificateAttributeContentProvider.java

@@ -47,7 +47,7 @@ public class X509CertificateAttributeContentProvider implements IStructuredConte
 	private static String LABEL_KEYUSAGE_ENCIPHERONLY = "encipherOnly"; //$NON-NLS-1$
 	private static String LABEL_KEYUSAGE_DECIPHERONLY = "decipherOnly"; //$NON-NLS-1$
 
-	private ArrayList<X509CertificateAttribute> elements = new ArrayList<>();
+	private final ArrayList<X509CertificateAttribute> elements = new ArrayList<>();
 	private Viewer viewer = null;
 	private static String listDelim = ", "; //$NON-NLS-1$
 

bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/storage/UICallbackProvider.java

@@ -35,7 +35,7 @@ public class UICallbackProvider implements IUICallbacks {
 
 	private static class InitWithProgress implements IRunnableWithProgress {
 
-		private IStorageTask callback;
+		private final IStorageTask callback;
 		private StorageException exception = null;
 
 		public InitWithProgress(IStorageTask callback) {

bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/storage/view/ValuesView.java

@@ -58,9 +58,9 @@ public class ValuesView {
 	protected Shell shell;
 
 	class TableValuesElement {
-		private String key;
+		private final String key;
 		private String value;
-		private boolean encrypted;
+		private final boolean encrypted;
 
 		public TableValuesElement(String key) {
 			this.key = key;

bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/wizard/CertificateImportTrustEngineSelectPage.java

@@ -27,7 +27,7 @@ public class CertificateImportTrustEngineSelectPage extends WizardPage implement
 
 	private Text aliasField;
 	private Combo trustEngineCombo;
-	private ArrayList<TrustEngine> trustEngines = new ArrayList<>();
+	private final ArrayList<TrustEngine> trustEngines = new ArrayList<>();
 
 	protected CertificateImportTrustEngineSelectPage(String pageName) {
 		super(pageName);

bundles/org.eclipse.equinox.security.ui/src/org/eclipse/equinox/internal/security/ui/wizard/CertificateViewer.java

@@ -23,9 +23,9 @@
 
 public class CertificateViewer {
 
-	private Composite composite;
+	private final Composite composite;
 
-	private TableViewer tableViewer;
+	private final TableViewer tableViewer;
 
 	public CertificateViewer(Composite parent) {
 		composite = new Composite(parent, SWT.None);