-
Notifications
You must be signed in to change notification settings - Fork 362
attempt to eliminate the first byte stream corruption in the EntityInputStream#isEmpty method #5806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
senivam
wants to merge
2
commits into
eclipse-ee4j:3.1
Choose a base branch
from
senivam:31_EntityInputStream
base: 3.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
109 changes: 109 additions & 0 deletions
109
...sey-servlet-core/src/main/java/org/glassfish/jersey/servlet/ServletEntityInputStream.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,109 @@ | ||
/* | ||
* Copyright (c) 2024, 2025 Oracle and/or its affiliates. All rights reserved. | ||
* | ||
* This program and the accompanying materials are made available under the | ||
* terms of the Eclipse Public License v. 2.0, which is available at | ||
* http://www.eclipse.org/legal/epl-2.0. | ||
* | ||
* This Source Code may also be made available under the following Secondary | ||
* Licenses when the conditions for such availability set forth in the | ||
* Eclipse Public License v. 2.0 are satisfied: GNU General Public License, | ||
* version 2 with the GNU Classpath Exception, which is available at | ||
* https://www.gnu.org/software/classpath/license.html. | ||
* | ||
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 | ||
*/ | ||
|
||
package org.glassfish.jersey.servlet; | ||
|
||
import jakarta.servlet.ReadListener; | ||
import jakarta.servlet.ServletInputStream; | ||
import org.glassfish.jersey.innate.io.ExternalStreamListener; | ||
import org.glassfish.jersey.innate.io.ExternalStreamWrapper; | ||
|
||
import java.io.IOException; | ||
import java.io.InputStream; | ||
import java.io.UncheckedIOException; | ||
import java.util.concurrent.CountDownLatch; | ||
import java.util.concurrent.TimeUnit; | ||
import java.util.concurrent.atomic.AtomicBoolean; | ||
|
||
abstract class ServletEntityInputStream implements ExternalStreamWrapper { | ||
|
||
private boolean waitForInputEnable; | ||
private long waitForInputTimeOut; | ||
|
||
private final ExternalStreamListener listener = new ExternalStreamListener() { | ||
|
||
@Override | ||
public boolean isEmpty() { | ||
try { | ||
return getWrappedStream().available() == 0 | ||
|| getWrappedStream().isFinished(); | ||
} catch (IOException e) { | ||
throw new UncheckedIOException(e); | ||
} | ||
} | ||
|
||
@Override | ||
public boolean isReady() { | ||
return processReadiness(); | ||
} | ||
|
||
boolean processReadiness() { | ||
|
||
final AtomicBoolean ready = new AtomicBoolean(getWrappedStream().isReady()); | ||
if (waitForInputEnable && !ready.get()) { | ||
|
||
final CountDownLatch latch = new CountDownLatch(1); | ||
|
||
getWrappedStream().setReadListener(new ReadListener() { | ||
@Override | ||
public void onDataAvailable() { | ||
ready.set(true); | ||
latch.countDown(); | ||
} | ||
|
||
@Override | ||
public void onAllDataRead() { | ||
ready.set(false); | ||
latch.countDown(); | ||
} | ||
|
||
@Override | ||
public void onError(Throwable t) { | ||
ready.set(false); | ||
latch.countDown(); | ||
} | ||
|
||
}); | ||
if (!ready.get()) { | ||
try { | ||
latch.await(waitForInputTimeOut, TimeUnit.MILLISECONDS); | ||
} catch (InterruptedException e) { | ||
ready.set(getWrappedStream().isReady()); | ||
} | ||
} | ||
} | ||
return ready.get() || getWrappedStream().isReady(); | ||
} | ||
|
||
}; | ||
|
||
public ServletEntityInputStream(boolean waitForInputEnable, long waitForInputTimeOut) { | ||
this.waitForInputEnable = waitForInputEnable; | ||
this.waitForInputTimeOut = waitForInputTimeOut; | ||
} | ||
|
||
protected abstract ServletInputStream getWrappedStream(); | ||
|
||
@Override | ||
public ExternalStreamListener getListener() { | ||
return listener; | ||
} | ||
|
||
@Override | ||
public InputStream getExternalStream() { | ||
return getWrappedStream(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
core-common/src/main/java/org/glassfish/jersey/innate/io/ExternalStreamListener.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/* | ||
* Copyright (c) 2025 Oracle and/or its affiliates. All rights reserved. | ||
* | ||
* This program and the accompanying materials are made available under the | ||
* terms of the Eclipse Public License v. 2.0, which is available at | ||
* http://www.eclipse.org/legal/epl-2.0. | ||
* | ||
* This Source Code may also be made available under the following Secondary | ||
* Licenses when the conditions for such availability set forth in the | ||
* Eclipse Public License v. 2.0 are satisfied: GNU General Public License, | ||
* version 2 with the GNU Classpath Exception, which is available at | ||
* https://www.gnu.org/software/classpath/license.html. | ||
* | ||
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 | ||
*/ | ||
|
||
package org.glassfish.jersey.innate.io; | ||
|
||
import org.glassfish.jersey.message.internal.EntityInputStream; | ||
|
||
import java.util.EventListener; | ||
|
||
/** | ||
* Provides possibility to externally check whether an input stream for an entity is empty or not. | ||
* <p> | ||
* Is being used in the {@link EntityInputStream#isEmpty()} check | ||
* </p> | ||
*/ | ||
public interface ExternalStreamListener extends EventListener { | ||
|
||
/** | ||
* Provides information if the underlying stream is empty | ||
* | ||
* @return true if the underlying stream is empty | ||
*/ | ||
boolean isEmpty(); | ||
|
||
/** | ||
* Can be used to provide readiness information. | ||
* <p> | ||
* If the stream is not ready the calling check in the {@link EntityInputStream#isEmpty()} method will validate | ||
* the underlying stream as not empty. | ||
* </p> | ||
* <p> | ||
* Throws: | ||
* IllegalStateException - if one of the following conditions is true | ||
* the associated request is neither upgraded nor the async started | ||
* underlying setReadListener is called more than once within the scope of the same request. | ||
* </p> | ||
* @return true if the underlying stream is ready. | ||
*/ | ||
boolean isReady(); | ||
} |
27 changes: 27 additions & 0 deletions
27
core-common/src/main/java/org/glassfish/jersey/innate/io/ExternalStreamWrapper.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/* | ||
* Copyright (c) 2025 Oracle and/or its affiliates. All rights reserved. | ||
* | ||
* This program and the accompanying materials are made available under the | ||
* terms of the Eclipse Public License v. 2.0, which is available at | ||
* http://www.eclipse.org/legal/epl-2.0. | ||
* | ||
* This Source Code may also be made available under the following Secondary | ||
* Licenses when the conditions for such availability set forth in the | ||
* Eclipse Public License v. 2.0 are satisfied: GNU General Public License, | ||
* version 2 with the GNU Classpath Exception, which is available at | ||
* https://www.gnu.org/software/classpath/license.html. | ||
* | ||
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 | ||
*/ | ||
|
||
package org.glassfish.jersey.innate.io; | ||
|
||
import java.io.InputStream; | ||
|
||
public interface ExternalStreamWrapper { | ||
|
||
ExternalStreamListener getListener(); | ||
|
||
InputStream getExternalStream(); | ||
|
||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.