Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adapt group name to fix release #137

Open
wants to merge 9 commits into
base: release/0.11.0
Choose a base branch
from
Open

fix: adapt group name to fix release #137

wants to merge 9 commits into from

Conversation

janpmeyer
Copy link
Contributor

What this PR changes/adds

Fixes properties for publishing Maven Artifacts.

Why it does that

The Properties are not algined yet to Eclipse Repos.

Who will sponsor this feature?

@ndr-brt

Linked Issue(s)

Closes #130

eclipse-edc-bot and others added 6 commits January 16, 2025 12:53
@eclipse-edc-bot
Bump version from 0.11.0-SNAPSHOT to 0.12.0-SNAPSHOT [skip ci]
3302318
@ndr-brt
ci: add missing permissions to release workflow
ebd5a79
@dependabot
chore(deps): bump org.assertj:assertj-core from 3.27.2 to 3.27.3 (ecl…
1374b14 
…ipse-edc#132)

Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.27.2 to 3.27.3.
- [Release notes](https://github.com/assertj/assertj/releases)
- [Commits](assertj/assertj@assertj-build-3.27.2...assertj-build-3.27.3)

---
updated-dependencies:
- dependency-name: org.assertj:assertj-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ndr-brt
build: fix compilation (eclipse-edc#133)
7cd7b53
@janpmeyer
fix: adapt gradle.properties to edc repository eclipse-edc#130
429397b
@janpmeyer
fix: refactor typo eclipse-edc#130
c04d208
@janpmeyer janpmeyer requested a review from ndr-brt February 4, 2025 10:16
@janpmeyer janpmeyer self-assigned this Feb 4, 2025
@janpmeyer janpmeyer added the bug Something isn't working label Feb 4, 2025
@janpmeyer janpmeyer changed the title 130 fix adapt group name fix: adapt group name to fix release Feb 4, 2025
ndr-brt
ndr-brt requested changes Feb 4, 2025
View reviewed changes
Copy link
Member

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a lot of changes have been brought into, please just fix the group id

@janpmeyer
Copy link
Contributor Author

But this is includes your PR from before with the needed added rights for the pipeline.

The release Branch is just missing your PR yet. If you want i can remove your commit, but i thought your changes of Pipeline Rights are needed to make it workable.

@ndr-brt
Copy link
Member

ndr-brt commented Feb 5, 2025

But this is includes your PR from before with the needed added rights for the pipeline.

The release Branch is just missing your PR yet. If you want i can remove your commit, but i thought your changes of Pipeline Rights are needed to make it workable.

I'm taking care of the release so I will eventually add missing pieces there if needed, please address only what's described in the issue. (note that same change will need to be applied to main)

@janpmeyer
Copy link
Contributor Author

@ndr-brt I reverted the changes you described. If you want me to create a new PR, i can do this also.

@janpmeyer janpmeyer requested a review from ndr-brt February 5, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndr-brt ndr-brt Awaiting requested review from ndr-brt

Assignees

@janpmeyer janpmeyer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@janpmeyer @ndr-brt @eclipse-edc-bot