fix: flaky integration test #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
force-pushed
the
fix/flaky_integration_tests
branch
2 times, most recently
from
ccef2e5 to
7c19c2b
Compare
paullatzelsperger
force-pushed
the
fix/flaky_integration_tests
branch
from
7c19c2b to
2dbe322
Compare
paullatzelsperger
force-pushed
the
fix/flaky_integration_tests
branch
from
5c60921 to
555366f
Compare
wolf4ood
approved these changes
Jul 18, 2024
paullatzelsperger
added a commit
to paullatzelsperger/MinimumViableDataspace
that referenced
this pull request
Jul 18, 2024
* fix: flaky int test * use proper deserialization of the catalog * renamed workflow * log * wait for DP to be available * log only if test failed
paullatzelsperger
added a commit
to paullatzelsperger/MinimumViableDataspace
that referenced
this pull request
Jul 18, 2024
* fix: flaky int test * use proper deserialization of the catalog * renamed workflow * log * wait for DP to be available * log only if test failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
use proper deserialization of the
Catalog[]response, so we can filter for theasset-1of theprovider-qnaconnector.Why it does that
previously it used hard-coded indices in JSONPath expressions, which is brittle due to the non-canonical form of JSON.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.