fix: Add missing audience validation when accessing management api with oauth #4784
+47
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scandinave
force-pushed
the
fix/audience-validation-in-api-management
branch
2 times, most recently
from
6c55097 to
2063bb3
Compare
scandinave
force-pushed
the
fix/audience-validation-in-api-management
branch
2 times, most recently
from
cc6d2fb to
994b0c5
Compare
|
Not sure about the use of the context and key value of the |
paullatzelsperger
added
enhancement
paullatzelsperger
requested changes
Feb 7, 2025
| @@ -96,6 +102,15 @@ public void initialize(ServiceExtensionContext context) { | |||
| throw new EdcException(message); | |||
| } | |||
|
|
|||
| if (audience == null) { | |||
| context.getMonitor().warning("No audience configured for delegated authentication, defaulting to the participantId"); | |||
There was a problem hiding this comment.
nit: re-use monitor from line 95
There was a problem hiding this comment.
I also replaced the previous context.monitor by the one form line 95.
...gated/src/main/java/org/eclipse/edc/api/auth/delegated/DelegatedAuthenticationExtension.java
Outdated
Show resolved
Hide resolved
...d/src/test/java/org/eclipse/edc/api/auth/delegated/DelegatedAuthenticationExtensionTest.java
Outdated
Show resolved
Hide resolved
...d/src/test/java/org/eclipse/edc/api/auth/delegated/DelegatedAuthenticationExtensionTest.java
Outdated
Show resolved
Hide resolved
| @@ -57,4 +73,34 @@ public void delegatedProvider(DelegatedAuthenticationExtension extension) { | |||
| verify(config).getLong(AUTH_CACHE_VALIDITY_MS, DEFAULT_CACHE_TIME_TO_LIVE); | |||
|
|
|||
| } | |||
|
|
|||
| @Test | |||
| void initializeWithAudience(ServiceExtensionContext context, ObjectFactory factory) { | |||
There was a problem hiding this comment.
instead of using the objectfactory, you can directly inject the DelegatedAuthExtension into the test method, c.f. the previous test method
There was a problem hiding this comment.
This is what I have done at first but if I do that the audience value is already injected with a null value before I can set it in the test.
scandinave
force-pushed
the
fix/audience-validation-in-api-management
branch
3 times, most recently
from
d2dcca6 to
2e40ac1
Compare
scandinave
force-pushed
the
fix/audience-validation-in-api-management
branch
from
2e40ac1 to
595a377
Compare
scandinave
force-pushed
the
fix/audience-validation-in-api-management
branch
from
595a377 to
95217df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
This PR add the audience Validation for the API management context
Why it does that
Not validating audience is a security risk.
Further notes
I have added some tests to validate the modification in the extension. But I could not find a way to change the value of an injected configuration field annotated by
@Settings. So I can't unit test that when I set an audience, everything works as expected.I have validated the code manually though.
Who will sponsor this feature?
@paullatzelsperger
Linked Issue(s)
Closes #4768
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.