Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Update NodeJS and dependencies #22557

Closed
wants to merge 2 commits into from
Closed

WIP: Update NodeJS and dependencies #22557

wants to merge 2 commits into from

Conversation

ScrewTSW
Copy link
Member

@ScrewTSW ScrewTSW commented Sep 26, 2023 •
edited
Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

test image is available at quay.io/eclipse/che-e2e:7.74.0-nj20.ts5

podman run --shm-size=2048m \
-v <local_path_to_/che/tests/e2e/report/>:/tmp/report:Z \
-v <local_path_to_/che/tests/e2e/report/ffmpeg_report/>:/tmp/ffmpeg_report:Z \
-e TS_SELENIUM_BASE_URL=<che_7.74.x/DS3.9.0_url> \
-e TS_SELENIUM_LOG_LEVEL=DEBUG \
-e TS_SELENIUM_OCP_USERNAME=<username> \
-e 'TS_SELENIUM_OCP_PASSWORD=<password>' \
-e DELETE_WORKSPACE_ON_FAILED_TEST=true \
-e TS_SELENIUM_START_WORKSPACE_TIMEOUT=120000 \
-e NODE_TLS_REJECT_UNAUTHORIZED=0 \
-e USERSTORY=SmokeTest \
-e TS_OCP_LOGIN_PAGE_PROVIDER_TITLE=<ocp_provider_name> \
-e VIDEO_RECORDING=true \
-e TS_SELENIUM_SINGLE_HOST=true \
quay.io/eclipse/che-e2e:7.74.0-nj20.ts5

Test Log

  The SmokeTest userstory
    Create workspace from factory:https://github.com/che-incubator/quarkus-api-example.git
          ? BrowserTabsUtil.navigateTo - https://devspaces.apps.sandbox-stage.gb17.p1.openshiftapps.com
          ? OcpRedHatLoginPage.login
          ? OcpLoginPage.waitAndClickOnLoginProviderTitle
          ? RedHatLoginPage.waitRedHatLoginWelcomePage
          ? RedHatLoginPage.waitAndConfirmCookiePolicy
          ? RedHatLoginPage.enterUserNameRedHat
          ? RedHatLoginPage.clickNextButton
          ? RedHatLoginPage.enterPasswordRedHat
          ? RedHatLoginPage.clickOnLoginButton
          ? RedHatLoginPage.waitDisappearanceRedHatLoginWelcomePage
          ? BrowserTabsUtil.maximize - TS_SELENIUM_LAUNCH_FULLSCREEN is set to true, maximizing window.
          ? Dashboard.waitStartingPageLoaderDisappearance
      ? Login (31943ms)
          ? Dashboard.waitPage
          ? WorkspaceHandlingTests.createAndOpenWorkspaceFromGitRepository - fetching user kubernetes namespace, storing auth token by getting workspaces API URL.
          ? ApiUrlResolver.obtainUserNamespace
          ? CheMultiuserAuthorizationHeaderHandler.get
(node:732) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
(Use `node --trace-warnings ...` to show where the warning was created)
          ? ApiUrlResolver.obtainUserNamespace - kubeapi success: osio-ci-devsandbox-periodic-stg-dev
          ? Dashboard.clickCreateWorkspaceButton
          ? CreateWorkspace.waitPage
          ? CreateWorkspace.waitTitleContains - text: "Create Workspace"
          ? BrowserTabsUtil.getCurrentWindowHandle
          ? CreateWorkspace.importFromGitUsingUI - factoryUrl: "https://github.com/che-incubator/quarkus-api-example.git"
          ? BrowserTabsUtil.waitAndSwitchToAnotherWindow
          ? BrowserTabsUtil.getAllWindowHandles
          ? BrowserTabsUtil.getAllWindowHandles
          ? BrowserTabsUtil.switchToWindow
      ? Create and open new workspace from factory:https://github.com/che-incubator/quarkus-api-example.git (1913ms)
      ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - obtained workspace name from workspace loader page: quarkus-api-example-pdjq
      ? Obtain workspace name from workspace loader page (12356ms)
          ? registerRunningWorkspace - with workspaceName:quarkus-api-example-pdjq
      ? Register running workspace
          ? ProjectAndFileTests.waitWorkspaceReadinessForCheCodeEditor - waiting for editor.
          ? ProjectAndFileTests.waitWorkspaceReadinessForCheCodeEditor - editor was opened in 59671 seconds.
      ? Wait workspace readiness (59672ms)
          ? Function.getProjectNameFromGitUrl - https://github.com/che-incubator/quarkus-api-example.git
          ? Function.getProjectNameFromGitUrl - quarkus-api-example
          ? Function.getProjectNameFromGitUrl - https://github.com/che-incubator/quarkus-api-example.git
          ? Function.getProjectNameFromGitUrl - quarkus-api-example
          ? Function.getProjectNameFromGitUrl - https://github.com/che-incubator/quarkus-api-example.git
          ? Function.getProjectNameFromGitUrl - quarkus-api-example
      ? Check a project folder has been created (643ms)
          ? projectSection.findItem: find devfile.yaml
      ? Check the project files was imported (308ms)
          ? Dashboard.openDashboard
          ? Dashboard.waitPage
          ? Dashboard.stopWorkspaceByUI - "quarkus-api-example-pdjq"
          ? Dashboard.clickWorkspacesButton
          ? Workspaces.waitPage
          ? Workspaces.waitWorkspaceListItem - "quarkus-api-example-pdjq"
          ? Workspaces.waitWorkspaceWithRunningStatus - "quarkus-api-example-pdjq"
          ? Workspaces.stopWorkspaceByActionsButton
          ? Workspaces.waitWorkspaceListItem - "quarkus-api-example-pdjq"
          ? Workspaces.openActionsPopup - for the 'quarkus-api-example-pdjq' list item
          ? Workspaces.clickActionsButton - of the 'quarkus-api-example-pdjq' list item
          ? Workspaces.waitActionsPopup - of the 'quarkus-api-example-pdjq' list item
          ? Workspaces.clickActionsStopWorkspaceButton - for the 'quarkus-api-example-pdjq' list item
          ? Workspaces.waitWorkspaceWithStoppedStatus - "quarkus-api-example-pdjq"
          ? BrowserTabsUtil.getAllWindowHandles
          ? BrowserTabsUtil.getCurrentWindowHandle
          ? BrowserTabsUtil.switchToWindow
          ? BrowserTabsUtil.switchToWindow
      ? Stop the workspace (8075ms)
          ? Dashboard.openDashboard
          ? Dashboard.waitPage
          ? Dashboard.deleteStoppedWorkspaceByUI - "quarkus-api-example-pdjq"
          ? Dashboard.clickWorkspacesButton
          ? Workspaces.waitPage
          ? Workspaces.waitWorkspaceListItem - "quarkus-api-example-pdjq"
          ? Workspaces.deleteWorkspaceByActionsButton
          ? Workspaces.waitWorkspaceListItem - "quarkus-api-example-pdjq"
          ? Workspaces.openActionsPopup - for the 'quarkus-api-example-pdjq' list item
          ? Workspaces.clickActionsButton - of the 'quarkus-api-example-pdjq' list item
          ? Workspaces.waitActionsPopup - of the 'quarkus-api-example-pdjq' list item
          ? Workspaces.clickActionsDeleteButton - for the 'quarkus-api-example-pdjq' list item
          ? Workspaces.waitDeleteWorkspaceConfirmationWindow
          ? Workspaces.clickToDeleteConfirmationCheckbox
          ? Workspaces.waitAndClickEnabledConfirmationWindowDeleteButton
          ? Workspaces.waitPage
          ? Workspaces.waitWorkspaceListItemAbsence - "quarkus-api-example-pdjq"
      ? Delete the workspace (9733ms)
          ? Dashboard.logout
          ? Dashboard.openDashboard
          ? Dashboard.waitPage
      ? Logout (8503ms)

      ? Context.stopTheDriver - Chrome driver session stopped.

  10 passing (2m)

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. labels Sep 26, 2023
@ScrewTSW ScrewTSW force-pushed the hotfix-updating-nodejs-and-dependencies branch from 4af19e7 to e229ef8 Compare September 26, 2023 16:20
@ScrewTSW ScrewTSW mentioned this pull request Sep 26, 2023
Merged
9 tasks
@ScrewTSW ScrewTSW force-pushed the hotfix-updating-nodejs-and-dependencies branch 2 times, most recently from 89e9d72 to ac3e4e4 Compare September 27, 2023 12:07
@ScrewTSW ScrewTSW force-pushed the hotfix-updating-nodejs-and-dependencies branch from ac3e4e4 to 85ef0fc Compare September 27, 2023 13:11
dmytro-ndp
dmytro-ndp reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScrewTSW: image quay.io/eclipse/che-e2e:7.74.0-nj20.ts5 has failed to run the test because of error:

22:50:09    1) Uncaught error outside test suite
22:50:09    [ERROR] CheReporter runner.on.fail: Uncaught error outside test suite failed after undefinedms

Test build: https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/DevSandbox/job/sandbox-test/8237/console

Could you please take a look?

@ibuziuk
Copy link
Member

ibuziuk commented Mar 5, 2024

@musienko-maxim @dmytro-ndp should we close this PR or it is planned to be merged at some point?

@ScrewTSW
Copy link
Member Author

ScrewTSW commented Apr 2, 2024

closing because outdated. recommend adapting the nodejs installation strategy though

@ScrewTSW ScrewTSW closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ndp dmytro-ndp dmytro-ndp left review comments

@musienko-maxim musienko-maxim musienko-maxim approved these changes

@nickboldt nickboldt Awaiting requested review from nickboldt nickboldt is a code owner

Assignees
No one assigned
Labels
status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ScrewTSW @ibuziuk @dmytro-ndp @musienko-maxim @che-bot