Fix: timeouts of waiting on extensions complete installation RecommendedExtensions test #22514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nallikaea
requested review from
musienko-maxim,
nickboldt,
ScrewTSW and
dmytro-ndp
as code owners
che-bot
added
target/branch
nallikaea
force-pushed
the
22502
branch
2 times, most recently
from
78a147b
to
0d9f9cc
Compare
nallikaea
changed the title
che-bot
added
the
kind/task
musienko-maxim
approved these changes
Sep 19, 2023
nallikaea
changed the title
|
https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/11960/ |
dmytro-ndp
reviewed
Sep 20, 2023
| @@ -10,6 +10,9 @@ | |||
| export const PLUGIN_TEST_CONSTANTS: { TS_SAMPLE_LIST: string } = { | |||
| /** | |||
| * dashboard samples to check in RecommendedExtensions.spec.ts | |||
| * full list Node.js MongoDB,Node.js Express,Java 11 with Lombok,Java 11 with Quarkus,Python,.NET,C/C++,Go,PHP,Ansible | |||
There was a problem hiding this comment.
this sentence looks redundant because is duplicating TS_SAMPLE_LIST constant value
dmytro-ndp
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
looks good to merge taking into account shared test results: #22514 (comment)
…dedExtensions test Signed-off-by: mdolhalo <[email protected]>
|
@nallikaea: new test run showed the expected result: https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/basic/job/typescript-tests/12045/console |
|
EmptyWorkspace PR check has passed as well https://github.com/eclipse/che/actions/runs/6258850326/job/16993691751?pr=22514 |
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
because of Automatic installation of Recommended extensions is failing on Java Samples. test failed by common timeout common 20min:
MOCHA_DEFAULT_TIMEOUT: process.env.MOCHA_DEFAULT_TIMEOUT || 1200000Added specific timeout test timeout
TS_FIND_EXTENSION_TEST_TIMEOUT * n, wheren- number of extensions.15s per extension by default.
Screenshot/screencast of this PR
NA
What issues does this PR fix or reference?
#22502
https://issues.redhat.com/browse/CRW-4790
How to test this PR?
docker run --shm-size=4096m -p 5920:5920 -e TS_SELENIUM_LOAD_PAGE_TIMEOUT=420000 -e TS_SELENIUM_BASE_URL=https://devspaces.apps.ocp413.crw-qe.com/ -e DELETE_WORKSPACE_ON_FAILED_TEST=true -e TS_SELENIUM_START_WORKSPACE_TIMEOUT=120000 -e NODE_TLS_REJECT_UNAUTHORIZED=0 -e VIDEO_RECORDING=true -e E2E_OCP_CLUSTER_API_URL=https://api.ocp413.crw-qe.com:6443/ -e TS_SELENIUM_LOG_LEVEL=TRACE -e TS_WAIT_LOADER_PRESENCE_TIMEOUT=120000 -e TS_COMMON_DASHBOARD_WAIT_TIMEOUT=30000 -e OCP_INFRA=PSI -v /tmp:/usr/local/bin:Z -v /home/hudson/.kube:/home/seluser/.kube:Z -v /mnt/hudson_workspace/workspace/Testing/e2e/basic/typescript-tests/test-repo/tests/e2e:/tmp/e2e:Z -v /mnt/hudson_workspace/workspace/Testing/e2e/basic/typescript-tests/test-repo/tests/e2e/video:/tmp/ffmpeg_report:Z -e USERSTORY=RecommendedExtensions -e TS_SELENIUM_VALUE_OPENSHIFT_OAUTH=true -e TS_OCP_LOGIN_PAGE_PROVIDER_TITLE=htpasswd -e TS_SELENIUM_OCP_USERNAME=admin -e 'TS_SAMPLE_LIST=Java 11 with Quarkus' -e TS_COMMON_DASHBOARD_WAIT_TIMEOUT=120_000 quay.io/eclipse/che-e2e:nextPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.