Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project import failures on che-dashboard prcheck #22471

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Fix project import failures on che-dashboard prcheck #22471

merged 1 commit into from
Sep 15, 2023

Conversation

ScrewTSW
Copy link
Member

@ScrewTSW ScrewTSW commented Sep 4, 2023 •
edited by dmytro-ndp
Loading

What does this PR do?

  • fixes project import check
  • simplifies dashboard workspace context button locator (test was failing on dogfooding because li segment had @role=none
  • updates vscode-extension-tester-locators version

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

#22450

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Test Run Logs

[tdancs@fedora e2e]$ USERSTORY='SmokeTest' MOCHA_DIRECTORY='.' npm run test

> @eclipse-che/[email protected] test
> ./configs/sh-scripts/initDefaultValues.sh npm run lint && npm run tsc && export USERSTORY=$USERSTORY && mocha --config dist/configs/mocharc.js

Initialized default values

TS_SELENIUM_VALUE_TLS_SUPPORT =       
TS_SELENIUM_VALUE_OPENSHIFT_OAUTH =   true
TS_OCP_LOGIN_PAGE_PROVIDER_TITLE =    github-app-sre
E2E_OCP_CLUSTER_VERSION =             4.x
TS_SELENIUM_LOG_LEVEL =               TRACE
TS_SELENIUM_OCP_USERNAME =            ScrewTSW
TS_SELENIUM_W3C_CHROME_OPTION =       true
NODE_TLS_REJECT_UNAUTHORIZED =        0
TS_SELENIUM_EDITOR =                  che-code

> @eclipse-che/[email protected] tsc
> rm -rf ./dist && ./configs/sh-scripts/generateIndex.sh && tsc -p .

Generating index.ts file...

################## Launch Information ##################

      TS_SELENIUM_BASE_URL: https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com
      TS_SELENIUM_HEADLESS: false
      TS_SELENIUM_OCP_USERNAME: ScrewTSW
      TS_SELENIUM_EDITOR:   che-code

      TS_SELENIUM_HAPPY_PATH_WORKSPACE_NAME: EmptyWorkspace
      TS_SELENIUM_DELAY_BETWEEN_SCREENSHOTS: 1000
      TS_SELENIUM_REPORT_FOLDER: ./report
      TS_SELENIUM_EXECUTION_SCREENCAST: false
      DELETE_SCREENCAST_IF_TEST_PASS: true
      TS_SELENIUM_REMOTE_DRIVER_URL: 
      DELETE_WORKSPACE_ON_FAILED_TEST: true
      TS_SELENIUM_LOG_LEVEL: TRACE
      TS_SELENIUM_LAUNCH_FULLSCREEN: true

      TS_COMMON_DASHBOARD_WAIT_TIMEOUT: 5000
      TS_SELENIUM_START_WORKSPACE_TIMEOUT: 360000
      TS_WAIT_LOADER_PRESENCE_TIMEOUT: 60000

      TS_SAMPLE_LIST: Node.js MongoDB,Node.js Express

      MOCHA_DIRECTORY: .
      USERSTORY: SmokeTest

      to output timeout variables, set TS_SELENIUM_PRINT_TIMEOUT_VARIABLES to true
 ######################################################## 


            ? DriverHelper.getDriver
  The SmokeTest userstory
    Create workspace from factory:https://github.com/che-incubator/quarkus-api-example.git
            ? DriverHelper.getDriver
          ? BrowserTabsUtil.navigateTo - https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com
            ? DriverHelper.getDriver
          ? RegularUserOcpCheLoginPage.login
          ? RegularUserOcpCheLoginPage.login - wait for LogInWithOpenShift page and click button
            ? DriverHelper.waitPresence - By(xpath, //div[@class="panel-login"])
            ? DriverHelper.waitAndClick - By(xpath, //div[@class="panel-login"]/div[contains(@class, 'panel-content')]/form/button)
            ? DriverHelper.waitVisibility - By(xpath, //div[@class="panel-login"]/div[contains(@class, 'panel-content')]/form/button)
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? OcpLoginPage.isIdentityProviderLinkVisible
            ? DriverHelper.waitVisibilityBoolean - By(xpath, //a[text()="github-app-sre"])
            ? DriverHelper.isVisible - By(xpath, //a[text()="github-app-sre"])
          ? OcpLoginPage.clickOnLoginProviderTitle
            ? DriverHelper.waitAndClick - By(xpath, //a[text()="github-app-sre"])
            ? DriverHelper.waitVisibility - By(xpath, //a[text()="github-app-sre"])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? OcpLoginPage.isAuthorizeOpenShiftIdentityProviderPageVisible
            ? DriverHelper.isVisible - By(xpath, //h1[text()="Authorize Access"])
            ? BrowserTabsUtil.maximize
          ? BrowserTabsUtil.maximize - TS_SELENIUM_LAUNCH_FULLSCREEN is set to true, maximizing window.
            ? DriverHelper.getDriver
          ? Dashboard.waitStartingPageLoaderDisappearance
            ? DriverHelper.waitDisappearance - By(css selector, .main-page-loader)
            ? DriverHelper.waitDisappearanceBoolean - By(css selector, .main-page-loader)
            ? DriverHelper.isVisible - By(css selector, .main-page-loader)
            ? DriverHelper.wait - (1000 milliseconds)
      ? Login (5509ms)
          ? Dashboard.waitPage
            ? DriverHelper.waitVisibility - By(xpath, //div[@id="page-sidebar"]//a[contains(text(), "Workspaces (")])
            ? DriverHelper.waitVisibility - polling timed out attempt #1, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #2, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #3, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #4, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #5, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #6, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #7, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #8, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - element is located and is visible.
            ? DriverHelper.waitVisibility - By(xpath, //div[@id="page-sidebar"]//a[text()="Create Workspace"])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? WorkspaceHandlingTests.createAndOpenWorkspaceFromGitRepository - fetching user kubernetes namespace, storing auth token by getting workspaces API URL.
          ? ApiUrlResolver.obtainUserNamespace
            ? ApiUrlResolver.obtainUserNamespace - USER_NAMESPACE.length = 0, calling kubernetes API
            ? DriverHelper.getDriver
(node:452253) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
(Use `node --trace-warnings ...` to show where the warning was created)
          ? ApiUrlResolver.obtainUserNamespace - kubeapi success: screwtsw-che-xmlol7
          ? Dashboard.clickCreateWorkspaceButton
            ? DriverHelper.waitAndClick - By(xpath, //div[@id="page-sidebar"]//a[text()="Create Workspace"])
            ? DriverHelper.waitVisibility - By(xpath, //div[@id="page-sidebar"]//a[text()="Create Workspace"])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? CreateWorkspace.waitPage
          ? CreateWorkspace.waitTitleContains - text: "Create Workspace"
            ? DriverHelper.waitVisibility - By(xpath, //h1[contains(text(), 'Create Workspace')])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? BrowserTabsUtil.getCurrentWindowHandle
            ? DriverHelper.getDriver
          ? CreateWorkspace.importFromGitUsingUI - factoryUrl: "https://github.com/che-incubator/quarkus-api-example.git"
            ? DriverHelper.waitVisibility - By(xpath, //input[@id="git-repo-url"])
            ? DriverHelper.waitVisibility - element is located and is visible.
            ? DriverHelper.type - By(xpath, //input[@id="git-repo-url"]) text: https://github.com/che-incubator/quarkus-api-example.git??
            ? DriverHelper.waitVisibility - By(xpath, //input[@id="git-repo-url"])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? BrowserTabsUtil.waitAndSwitchToAnotherWindow
            ? DriverHelper.waitUntilTrue
          ? BrowserTabsUtil.getAllWindowHandles
            ? DriverHelper.getDriver
          ? BrowserTabsUtil.getAllWindowHandles
            ? DriverHelper.getDriver
          ? BrowserTabsUtil.switchToWindow
            ? DriverHelper.getDriver
      ? Create and open new workspace from factory:https://github.com/che-incubator/quarkus-api-example.git (15447ms)
            ? DriverHelper.getDriver
            ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - failed to obtain name from workspace start page, element not visible yet. Retrying.
            ? DriverHelper.wait - (1000 milliseconds)
            ? DriverHelper.getDriver
            ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - failed to obtain name from workspace start page, element not visible yet. Retrying.
            ? DriverHelper.wait - (1000 milliseconds)
            ? DriverHelper.getDriver
            ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - failed to obtain name from workspace start page, element not visible yet. Retrying.
            ? DriverHelper.wait - (1000 milliseconds)
            ? DriverHelper.getDriver
            ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - failed to obtain name from workspace start page, element not visible yet. Retrying.
            ? DriverHelper.wait - (1000 milliseconds)
            ? DriverHelper.getDriver
            ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - failed to obtain name from workspace start page, element not visible yet. Retrying.
            ? DriverHelper.wait - (1000 milliseconds)
            ? DriverHelper.getDriver
            ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - failed to obtain name from workspace start page, element not visible yet. Retrying.
            ? DriverHelper.wait - (1000 milliseconds)
            ? DriverHelper.getDriver
            ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - failed to obtain name from workspace start page, element not visible yet. Retrying.
            ? DriverHelper.wait - (1000 milliseconds)
            ? DriverHelper.getDriver
            ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - failed to obtain name from workspace start page, element not visible yet. Retrying.
            ? DriverHelper.wait - (1000 milliseconds)
            ? DriverHelper.getDriver
            ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - failed to obtain name from workspace start page, element not visible yet. Retrying.
            ? DriverHelper.wait - (1000 milliseconds)
            ? DriverHelper.getDriver
            ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - failed to obtain name from workspace start page, element not visible yet. Retrying.
            ? DriverHelper.wait - (1000 milliseconds)
            ? DriverHelper.getDriver
            ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - obtained starting workspace getText():Starting workspace quarkus-api-example-pft9
            ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - trimmed workspace name from getText():quarkus-api-example-pft9
      ? WorkspaceHandlingTests.obtainWorkspaceNameFromStartingPage - obtained workspace name from workspace loader page: quarkus-api-example-pft9
      ? Obtain workspace name from workspace loader page (10585ms)
          ? Object.registerRunningWorkspace - with workspaceName:quarkus-api-example-pft9
      ? Register running workspace
          ? ProjectAndFileTests.waitWorkspaceReadinessForCheCodeEditor - waiting for editor.
            ? DriverHelper.getDriver
          ? ProjectAndFileTests.waitWorkspaceReadinessForCheCodeEditor - editor was opened in 41942 seconds.
      ? Wait workspace readiness (41947ms)
          ? Function.getProjectNameFromGitUrl - https://github.com/che-incubator/quarkus-api-example.git
          ? Function.getProjectNameFromGitUrl - quarkus-api-example
          ? Function.getProjectNameFromGitUrl - https://github.com/che-incubator/quarkus-api-example.git
          ? Function.getProjectNameFromGitUrl - quarkus-api-example
      ? Check a project folder has been created (310ms)
          ? projectSection.findItem: find devfile.yaml
      ? Check the project files was imported (142ms)
          ? Dashboard.openDashboard
            ? DriverHelper.getDriver
          ? Dashboard.waitPage
            ? DriverHelper.waitVisibility - By(xpath, //div[@id="page-sidebar"]//a[contains(text(), "Workspaces (")])
            ? DriverHelper.waitVisibility - polling timed out attempt #1, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #2, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - element is located and is visible.
            ? DriverHelper.waitVisibility - By(xpath, //div[@id="page-sidebar"]//a[text()="Create Workspace"])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Dashboard.stopWorkspaceByUI - "quarkus-api-example-pft9"
          ? Dashboard.clickWorkspacesButton
            ? DriverHelper.waitAndClick - By(xpath, //div[@id="page-sidebar"]//a[contains(text(), "Workspaces (")])
            ? DriverHelper.waitVisibility - By(xpath, //div[@id="page-sidebar"]//a[contains(text(), "Workspaces (")])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.waitPage
            ? DriverHelper.waitVisibility - By(xpath, //button[text()="Add Workspace"])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.waitWorkspaceListItem - "quarkus-api-example-pft9"
            ? DriverHelper.waitVisibility - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.waitWorkspaceWithRunningStatus - "quarkus-api-example-pft9"
            ? DriverHelper.waitVisibility - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']]//span[@data-testid='workspace-status-indicator']//*[local-name()='svg' and @fill='green'])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.stopWorkspaceByActionsButton - Workspaces.stopWorkspaceByActionsButton
          ? Workspaces.waitWorkspaceListItem - "quarkus-api-example-pft9"
            ? DriverHelper.waitVisibility - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.openActionsPopup - for the 'quarkus-api-example-pft9' list item
          ? Workspaces.clickActionsButton - of the 'quarkus-api-example-pft9' list item
            ? DriverHelper.waitAndClick - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']]/td/div/button[@aria-label='Actions'])
            ? DriverHelper.waitVisibility - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']]/td/div/button[@aria-label='Actions'])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.waitActionsPopup - of the 'quarkus-api-example-pft9' list item
            ? DriverHelper.waitVisibility - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']]//button[@aria-label='Actions' and @aria-expanded='true'])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.clickActionsStopWorkspaceButton - for the 'quarkus-api-example-pft9' list item
            ? DriverHelper.waitAndClick - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']]//button[text()='Stop Workspace'])
            ? DriverHelper.waitVisibility - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']]//button[text()='Stop Workspace'])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.waitWorkspaceWithStoppedStatus - "quarkus-api-example-pft9"
            ? DriverHelper.waitVisibility - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']]//span[@data-testid='workspace-status-indicator']//*[local-name()='svg' and @fill='grey'])
            ? DriverHelper.waitVisibility - element is located and is visible.
            ? BrowserTabsUtil.closeAllTabsExceptCurrent
          ? BrowserTabsUtil.getAllWindowHandles
            ? DriverHelper.getDriver
          ? BrowserTabsUtil.getCurrentWindowHandle
            ? DriverHelper.getDriver
          ? BrowserTabsUtil.switchToWindow
            ? DriverHelper.getDriver
            ? DriverHelper.getDriver
          ? BrowserTabsUtil.switchToWindow
            ? DriverHelper.getDriver
      ? Stop the workspace (4800ms)
          ? Dashboard.openDashboard
            ? DriverHelper.getDriver
          ? Dashboard.waitPage
            ? DriverHelper.waitVisibility - By(xpath, //div[@id="page-sidebar"]//a[contains(text(), "Workspaces (")])
            ? DriverHelper.waitVisibility - polling timed out attempt #1, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #2, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #3, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - element is located and is visible.
            ? DriverHelper.waitVisibility - By(xpath, //div[@id="page-sidebar"]//a[text()="Create Workspace"])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Dashboard.deleteStoppedWorkspaceByUI - "quarkus-api-example-pft9"
          ? Dashboard.clickWorkspacesButton
            ? DriverHelper.waitAndClick - By(xpath, //div[@id="page-sidebar"]//a[contains(text(), "Workspaces (")])
            ? DriverHelper.waitVisibility - By(xpath, //div[@id="page-sidebar"]//a[contains(text(), "Workspaces (")])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.waitPage
            ? DriverHelper.waitVisibility - By(xpath, //button[text()="Add Workspace"])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.waitWorkspaceListItem - "quarkus-api-example-pft9"
            ? DriverHelper.waitVisibility - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.deleteWorkspaceByActionsButton - Workspaces.deleteWorkspaceByActionsButton
          ? Workspaces.waitWorkspaceListItem - "quarkus-api-example-pft9"
            ? DriverHelper.waitVisibility - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.openActionsPopup - for the 'quarkus-api-example-pft9' list item
          ? Workspaces.clickActionsButton - of the 'quarkus-api-example-pft9' list item
            ? DriverHelper.waitAndClick - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']]/td/div/button[@aria-label='Actions'])
            ? DriverHelper.waitVisibility - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']]/td/div/button[@aria-label='Actions'])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.waitActionsPopup - of the 'quarkus-api-example-pft9' list item
            ? DriverHelper.waitVisibility - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']]//button[@aria-label='Actions' and @aria-expanded='true'])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.clickActionsDeleteButton - for the 'quarkus-api-example-pft9' list item
            ? DriverHelper.waitAndClick - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']]//button[text()='Delete Workspace'])
            ? DriverHelper.waitVisibility - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']]//button[text()='Delete Workspace'])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.waitDeleteWorkspaceConfirmationWindow
            ? DriverHelper.waitVisibility - By(xpath, //div[@aria-label="Delete workspaces confirmation window"])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.clickToDeleteConfirmationCheckbox - Workspaces.clickToDeleteConfirmationCheckbox
            ? DriverHelper.waitAndClick - By(xpath, //input[@data-testid="confirmation-checkbox"])
            ? DriverHelper.waitVisibility - By(xpath, //input[@data-testid="confirmation-checkbox"])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.waitAndClickEnabledConfirmationWindowDeleteButton - Workspaces.waitEnabledConfirmationWindowDeleteButton
            ? DriverHelper.waitAndClick - By(xpath, //button[@data-testid="delete-workspace-button" and not(@disabled)])
            ? DriverHelper.waitVisibility - By(xpath, //button[@data-testid="delete-workspace-button" and not(@disabled)])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.waitPage
            ? DriverHelper.waitVisibility - By(xpath, //button[text()="Add Workspace"])
            ? DriverHelper.waitVisibility - element is located and is visible.
          ? Workspaces.waitWorkspaceListItemAbsence - Workspaces.waitWorkspaceListItemAbsence "quarkus-api-example-pft9"
            ? DriverHelper.waitDisappearance - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']])
            ? DriverHelper.waitDisappearanceBoolean - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']])
            ? DriverHelper.isVisible - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']])
            ? DriverHelper.wait - (1000 milliseconds)
            ? DriverHelper.isVisible - By(xpath, //tr[td/span/a[text()='quarkus-api-example-pft9']])
      ? Delete the workspace (6050ms)
          ? Dashboard.logout
          ? Dashboard.openDashboard
            ? DriverHelper.getDriver
          ? Dashboard.waitPage
            ? DriverHelper.waitVisibility - By(xpath, //div[@id="page-sidebar"]//a[contains(text(), "Workspaces (")])
            ? DriverHelper.waitVisibility - polling timed out attempt #1, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #2, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #3, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #4, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #5, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #6, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #7, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #8, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #9, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #10, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #11, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #12, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #13, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #14, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #15, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #16, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #17, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #18, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #19, retrying with 1000ms timeout
  [ERROR] DriverHelper.waitVisibility - failed with exception, out of attempts - TimeoutError: Waiting for element to be located By(xpath, //div[@id="page-sidebar"]//a[contains(text(), "Workspaces (")])
  Wait timed out after 1065ms
          ? Dashboard.logout
          ? Dashboard.openDashboard
            ? DriverHelper.getDriver
          ? Dashboard.waitPage
            ? DriverHelper.waitVisibility - By(xpath, //div[@id="page-sidebar"]//a[contains(text(), "Workspaces (")])
            ? DriverHelper.waitVisibility - polling timed out attempt #1, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - polling timed out attempt #2, retrying with 1000ms timeout
            ? DriverHelper.waitVisibility - element is located and is visible.
            ? DriverHelper.waitVisibility - By(xpath, //div[@id="page-sidebar"]//a[text()="Create Workspace"])
            ? DriverHelper.waitVisibility - element is located and is visible.
            ? DriverHelper.waitAndClick - By(xpath, //header//button/span[text()!=""]//parent::button)
            ? DriverHelper.waitVisibility - By(xpath, //header//button/span[text()!=""]//parent::button)
            ? DriverHelper.waitVisibility - element is located and is visible.
            ? DriverHelper.waitAndClick - By(xpath, //button[text()="Logout"])
            ? DriverHelper.waitVisibility - By(xpath, //button[text()="Logout"])
            ? DriverHelper.waitVisibility - element is located and is visible.
            ? DriverHelper.waitDisappearance - By(xpath, //header//button/span[text()!=""]//parent::button)
            ? DriverHelper.waitDisappearanceBoolean - By(xpath, //header//button/span[text()!=""]//parent::button)
            ? DriverHelper.isVisible - By(xpath, //header//button/span[text()!=""]//parent::button)
      ? Logout (4321ms)

            ? DriverHelper.getDriver
      ? Context.stopTheDriver - Chrome driver session stopped.

  10 passing (2m)

            ? DriverHelper.wait - (5000 milliseconds)
            ? DriverHelper.getDriver

@che-bot che-bot added kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Sep 4, 2023
ibuziuk
ibuziuk reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general it is strange that the test is failing on PROW CI (PR check), but is running fine against Developer Sandbox

@nallikaea
Copy link
Contributor

Can we implement solution using mocha framework, not adding more logic in spec files directly?

@ScrewTSW ScrewTSW changed the title Fix project import failures on che-dashboard prcheck Draft: Fix project import failures on che-dashboard prcheck Sep 4, 2023
@ScrewTSW ScrewTSW force-pushed the hotfix-fixing-wait-for-project-import-logic-instability branch from e5147e1 to 1afcbf4 Compare September 4, 2023 16:19
@ScrewTSW ScrewTSW changed the title Draft: Fix project import failures on che-dashboard prcheck Fix project import failures on che-dashboard prcheck Sep 4, 2023
@ScrewTSW
Copy link
Member Author

ScrewTSW commented Sep 4, 2023

Problem was actually elsewhere, I now have a successful run, logs in PR description

@dmytro-ndp
Copy link
Contributor

@ScrewTSW : this PR should fix #22450 as well, if I understood it correctly, shouldn't it?

@ScrewTSW
Copy link
Member Author

ScrewTSW commented Sep 5, 2023

@ScrewTSW : this PR should fix #22450 as well, if I understood it correctly, shouldn't it?

Yes it should I think

@dmytro-ndp
Copy link
Contributor

@ScrewTSW : great!
I am trying to check fixup on https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Che/job/ocp/job/Disconnected/job/periodic-eclipse-che-tests/

@dmytro-ndp dmytro-ndp mentioned this pull request Sep 5, 2023
Open
@dmytro-ndp
Copy link
Contributor

dmytro-ndp commented Sep 5, 2023 •
edited
Loading

@ScrewTSW : it turned out that there is no simple way to check if this PR is fixing #22450

@ScrewTSW ScrewTSW force-pushed the hotfix-fixing-wait-for-project-import-logic-instability branch from 1afcbf4 to ca8c8bc Compare September 14, 2023 13:37
@ScrewTSW ScrewTSW merged commit d3da844 into eclipse-che:main Sep 15, 2023
3 checks passed
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 15, 2023
This was referenced Sep 18, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuziuk ibuziuk ibuziuk left review comments

@musienko-maxim musienko-maxim musienko-maxim approved these changes

@nickboldt nickboldt Awaiting requested review from nickboldt

@dmytro-ndp dmytro-ndp Awaiting requested review from dmytro-ndp dmytro-ndp is a code owner

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ScrewTSW @nallikaea @dmytro-ndp @ibuziuk @musienko-maxim @che-bot