Standardization of "che" test automation framework classes #22466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nallikaea
requested review from
musienko-maxim,
nickboldt,
ScrewTSW and
dmytro-ndp
as code owners
che-bot
added
status/code-review
nallikaea
force-pushed
the
global_refactoring
branch
from
0625b77
to
80bbaba
Compare
nallikaea
changed the title
nallikaea
force-pushed
the
global_refactoring
branch
from
80bbaba
to
babeb1b
Compare
…ODE_STYLE.md Signed-off-by: mdolhalo <[email protected]>
nallikaea
force-pushed
the
global_refactoring
branch
from
babeb1b
to
d185316
Compare
che-bot
added
the
kind/task
musienko-maxim
approved these changes
Sep 4, 2023
dmytro-ndp
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
E2E typescript test run against Dev Spaces 3.8.0 didn't show regression https://main-jenkins-csb-crwqe.apps.ocp-c1.prod.psi.redhat.com/job/Testing/job/e2e/job/complex/job/latest/job/functional-tests/893/console
Changes kook good to merge.
Good job, @nallikaea
che-bot
removed
the
status/code-review
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In "che/tests/e2e" there a lot of classes as page objects or utils. The same type of classes may had different structure.
There was created Coding Standards and Conventions file, and fixes were implemented according to it.
What does this PR do?
Screenshot/screencast of this PR
NA
What issues does this PR fix or reference?
Closes #22184
How to test this PR?
npm tun test
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.