-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"DevConsole integration" regression test case automation #22181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nallikaea
requested review from
musienko-maxim,
nickboldt,
ScrewTSW and
dmytro-ndp
as code owners
April 26, 2023 13:55
che-bot
added
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
target/branch
Indicates that a PR will be merged into a branch other than master.
labels
Apr 26, 2023
nallikaea
changed the title
"DevConsole integration" regression test case automation
WIP: "DevConsole integration" regression test case automation
Apr 26, 2023
|
nallikaea
changed the title
WIP: "DevConsole integration" regression test case automation
"DevConsole integration" regression test case automation
Apr 26, 2023
nallikaea
force-pushed
the
devconsole
branch
2 times, most recently
from
April 26, 2023 18:27
fd5bc9c
to
a58133a
Compare
Signed-off-by: mdolhalo <[email protected]>
Signed-off-by: mdolhalo <[email protected]>
ScrewTSW
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impresive fix! LGTM
dmytro-ndp
reviewed
Apr 27, 2023
dmytro-ndp
reviewed
Apr 27, 2023
dmytro-ndp
reviewed
Apr 27, 2023
dmytro-ndp
reviewed
Apr 27, 2023
dmytro-ndp
reviewed
Apr 27, 2023
tests/e2e/specs/devconsole-intergration/DevConsoleIntegration.spec.ts
Outdated
Show resolved
Hide resolved
dmytro-ndp
reviewed
Apr 27, 2023
dmytro-ndp
reviewed
Apr 27, 2023
dmytro-ndp
reviewed
Apr 27, 2023
dmytro-ndp
reviewed
Apr 27, 2023
dmytro-ndp
reviewed
Apr 27, 2023
dmytro-ndp
reviewed
Apr 27, 2023
tests/e2e/specs/devconsole-intergration/DevConsoleIntegration.spec.ts
Outdated
Show resolved
Hide resolved
musienko-maxim
approved these changes
Apr 27, 2023
…stAttempt(), deleted "as unknown as string", lint fixups Signed-off-by: mdolhalo <[email protected]>
dmytro-ndp
reviewed
Apr 28, 2023
test run after fixes
|
…ateProject() method Signed-off-by: mdolhalo <[email protected]>
dmytro-ndp
approved these changes
May 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge.
che-bot
removed
the
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
label
May 3, 2023
nallikaea
added a commit
to nallikaea/che
that referenced
this pull request
May 9, 2023
…#22181) Signed-off-by: mdolhalo <[email protected]>
nallikaea
added a commit
to nallikaea/che
that referenced
this pull request
Jun 6, 2023
…#22181) Signed-off-by: mdolhalo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Screenshot/screencast of this PR
Screencast.from.26.04.23.20.18.41.webm
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-4199
test-case
How to test this PR?
export USERSTORY=DevConsoleIntegration && npm run test
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.