Rename word to MAU and add link to settings docs #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreineckearm
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Thanks, @planger ! Changes look good. And adding the question button to open the future "Memory Format" section in the README should be a good but not too strong way to allow users to find out about the MAU.
@colin-grant-work , are you happy with this change as well? Then we can drive to merge, probably after merging #108 if that makes resolving merge conflicts easier than the other way around.
1 task
|
Changes look good to me, but I merged #108 before I saw this, so now there are conflicts in the data column. |
|
No problem, I merged the updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Renames the term word to MAU as discussed in #100 for the user-facing UI and in the code. In the options widget we also added a link to the soon-to-be existing documentation contributed in #109 and add hovers above the use of the term MAU.
How to test
As this touches several files, we should make sure the functionality isn't impacted at all.
Also it makes sense to do another search for the term word and make sure we caught all occurrences.
Review checklist
Reminder for reviewers