Rework waitForOutputEvent to not miss events #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code used to do this.once('output') in a tight loop,
but this meant that between processing one of the iterations
and the next iteration of the loop a message may have
been output. Instead use this.on('output') so all messages
are processed.
Prerequisite for eclipse-cdt-cloud#239 which generates multiple events quickly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code used to do
this.once('output')in a tight loop, but this meant that between processing one of the iterations and the next iteration of the loop a message may have been output. Instead usethis.on('output')so all messages are processed.Prerequisite for #239 which generates multiple events quickly