-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preliminary PDF/UA support #1972
base: master
Are you sure you want to change the base?
Preliminary PDF/UA support #1972
Conversation
…all setStrokeColor when a system property is set
One of the tests is failing: This obviously means that a tag-type attribute got lost. This might be related to one of my changes: AFAIK the tags are case-sensitive, for example it must be Probably now the value of So I think I have to modify the "golden" file, do I? |
@hvbtup Yes, go ahead. |
Nah. By examining the test, I see that the "golden" image is not a file. It is the report, loaded with |
@hvbtup |
As I said yesterday, I think my changes are now in a state that they do no harm to the master branch; creating normal PDFs should work exactly as before.
It is now possible to at least generate valid single-page PDF/UA files.
The smiling sun image is my IP, I created it a few years ago for a game experiment.
I cannot split this into more smaller commits in a reasonable way.
Note: The Java code certainly has some room for improvements.
In several cases I used the
instanceof
operator, because it was the easiest solution and avoids having to change interfaces.BTW most of the changes in EngineIRVisitor.java were suggested by the IDE to remove warnings.