-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes AASPolingConsumer NullpointerException #307
Conversation
[Yesterday 14:37] Fried, Jannik Oliver Co-authored-by: FriedJannik <[email protected]>
Co-authored-by: FriedJannik <[email protected]>
|
||
|
||
public static String getResponseAsString(CloseableHttpResponse retrievalResponse) throws IOException, ParseException { | ||
return EntityUtils.toString(retrievalResponse.getEntity(), "UTF-8"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is just a single line method, we can do this inline and then remove this method. What do you think?
} | ||
|
||
public static CloseableHttpResponse executeGetOnURL(String url) throws IOException { | ||
CloseableHttpClient client = HttpClients.createDefault(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some vertical spacing.
HttpGet aasCreateRequest = new HttpGet(url); | ||
aasCreateRequest.setHeader("Content-type", "application/json"); | ||
aasCreateRequest.setHeader("Accept", "application/json"); | ||
return aasCreateRequest; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add vertical spacing.
@@ -0,0 +1,293 @@ | |||
/******************************************************************************* | |||
* Copyright (C) 2021 the Eclipse BaSyx Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please change the year of this license to 2024?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Above are some of the remarks
Co-authored-by: FriedJannik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Closes #303