Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes AASPolingConsumer NullpointerException #307

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

aaronzi
Copy link
Member

@aaronzi aaronzi commented Jun 6, 2024

Closes #303



public static String getResponseAsString(CloseableHttpResponse retrievalResponse) throws IOException, ParseException {
return EntityUtils.toString(retrievalResponse.getEntity(), "UTF-8");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is just a single line method, we can do this inline and then remove this method. What do you think?

}

public static CloseableHttpResponse executeGetOnURL(String url) throws IOException {
CloseableHttpClient client = HttpClients.createDefault();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some vertical spacing.

HttpGet aasCreateRequest = new HttpGet(url);
aasCreateRequest.setHeader("Content-type", "application/json");
aasCreateRequest.setHeader("Accept", "application/json");
return aasCreateRequest;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add vertical spacing.

@@ -0,0 +1,293 @@
/*******************************************************************************
* Copyright (C) 2021 the Eclipse BaSyx Authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change the year of this license to 2024?

Copy link
Contributor

@mdanish98 mdanish98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above are some of the remarks

Copy link
Contributor

@mdanish98 mdanish98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@aaronzi aaronzi merged commit 993fefc into eclipse-basyx:main Jul 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

databridge MQTT configuration
2 participants